Makes fid optionally null so that we can delete the fid later
ClosedPublic
Actions

Authored by will on Apr 16 2024, 2:34 PM.

Details

Reviewers

ashoat
ginsu
atul

Commits

rCOMM97e642832c6e: Makes fid optionally null so that we can delete the fid later

Summary

Whenever we set farcaster friends when connecting a new farcaster account, we want to clear previous farcaster entries to keep things up to date.
This means that fid should be optionally null so we can clear without deleting other auxUserStore fields.

Test Plan

dispatched setFarcasterFriendsFIDActionType with null and string fids and checked sqlite database that everything was stored properly

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Apr 16 2024, 2:34 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 16 2024, 2:34 PM

will added a child revision: D11639: [lib] Add farcaster friend fids to sqlite.Apr 16 2024, 2:35 PM

Harbormaster completed remote builds in B28252: Diff 39163.Apr 16 2024, 2:50 PM

will requested review of this revision.Apr 16 2024, 2:50 PM

will added a child revision: D11672: create new aux user store action for clearing fids.Apr 16 2024, 3:20 PM

will removed a child revision: D11639: [lib] Add farcaster friend fids to sqlite.Apr 16 2024, 3:29 PM

ashoat accepted this revision.Apr 17 2024, 6:30 AM

This revision is now accepted and ready to land.Apr 17 2024, 6:30 AM

Closed by commit rCOMM97e642832c6e: Makes fid optionally null so that we can delete the fid later (authored by will). · Explain WhyApr 18 2024, 9:13 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM97e642832c6e: Makes fid optionally null so that we can delete the fid later.

Revision Contents
Changeset List

Path

Size

lib/

types/

aux-user-types.js

2 lines

Diff 39266

View Options

lib/types/aux-user-types.js

	// @flow			// @flow

	import invariant from 'invariant';			import invariant from 'invariant';
	import * as React from 'react';			import * as React from 'react';

	import { unreadBackgroundCount } from 'lib/selectors/thread-selectors.js';			import { unreadBackgroundCount } from 'lib/selectors/thread-selectors.js';

	import css from './chat-tabs.css';			import css from './chat-tabs.css';
	import ChatThreadList from './chat-thread-list.react.js';			import ChatThreadList from './chat-thread-list.react.js';
	import ChatThreadTab from './chat-thread-tab.react.js';
	import { ThreadListContext } from './thread-list-provider.js';			import { ThreadListContext } from './thread-list-provider.js';
	import Tabs from '../components/tabs-legacy.react.js';			import Tabs, { type TabData } from '../components/tabs.react.js';
	import { useSelector } from '../redux/redux-utils.js';			import { useSelector } from '../redux/redux-utils.js';

				type TabType = 'Background' \| 'Focus';

	function ChatTabs(): React.Node {			function ChatTabs(): React.Node {
	let backgroundTitle = 'Background';			let backgroundTitle = 'Background';
	const unreadBackgroundCountVal = useSelector(unreadBackgroundCount);			const unreadBackgroundCountVal = useSelector(unreadBackgroundCount);
	if (unreadBackgroundCountVal) {			if (unreadBackgroundCountVal) {
	backgroundTitle += ` (${unreadBackgroundCountVal})`;			backgroundTitle += ` (${unreadBackgroundCountVal})`;
	}			}

				const tabsData: $ReadOnlyArray<TabData<TabType>> = React.useMemo(
				() => [
				{
				id: 'Focus',
				header: 'Focused',
				},
				{
				id: 'Background',
				header: backgroundTitle,
				},
				],
				[backgroundTitle],
				);

	const threadListContext = React.useContext(ThreadListContext);			const threadListContext = React.useContext(ThreadListContext);
	invariant(			invariant(
	threadListContext,			threadListContext,
	'threadListContext should be set in ChatThreadList',			'threadListContext should be set in ChatThreadList',
	);			);
	const { activeTab, setActiveTab } = threadListContext;			const { activeTab, setActiveTab } = threadListContext;

	const setActiveChatTab = React.useCallback(			const tabs = React.useMemo(
	(newTab: 'Background' \| 'Focus') => {			() => (
	setActiveTab(newTab);			<Tabs
	},			tabItems={tabsData}
	[setActiveTab],			activeTab={activeTab}
				setTab={setActiveTab}
				headerStyle="pill"
				/>
				),
				[activeTab, setActiveTab, tabsData],
	);			);

	const chatThreadList = React.useMemo(			const chatTabs = React.useMemo(
	() => (			() => (
				<div className={css.container}>
				{tabs}
	<div className={css.threadList}>			<div className={css.threadList}>
	<ChatThreadList />			<ChatThreadList />
	</div>			</div>
				</div>
	),			),
	[],			[tabs],
	);

	const focusTabsItem = React.useMemo(
	() => (
	<Tabs.Item id="Focus" header={<ChatThreadTab title="Focused" />}>
	{chatThreadList}
	</Tabs.Item>
	),
	[chatThreadList],
	);

	const backgroundTabsItem = React.useMemo(
	() => (
	<Tabs.Item
	id="Background"
	header={<ChatThreadTab title={backgroundTitle} />}
	>
	{chatThreadList}
	</Tabs.Item>
	),
	[backgroundTitle, chatThreadList],
	);			);

	return (			return chatTabs;
	<div className={css.container}>
	<Tabs.Container
	activeTab={activeTab}
	setTab={setActiveChatTab}
	headerStyle="pill"
	>
	{focusTabsItem}
	{backgroundTabsItem}
	</Tabs.Container>
	</div>
	);
	}			}

	export default ChatTabs;			export default ChatTabs;

Makes fid optionally null so that we can delete the fid laterClosedPublicActions