Paths

Table of Contentst

Differential D11671

Makes fid optionally null so that we can delete the fid later
ClosedPublic
Actions

Authored by will on Tue, Apr 16, 2:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 24, 11:18 AM

	Unknown Object (File)
	Mon, Apr 22, 11:23 AM

	Unknown Object (File)
	Sat, Apr 20, 9:14 AM

	Unknown Object (File)
	Wed, Apr 17, 7:34 AM

	Unknown Object (File)
	Wed, Apr 17, 7:33 AM

	Unknown Object (File)
	Wed, Apr 17, 7:32 AM

Subscribers

Details

Reviewers

ashoat
ginsu
atul

Commits

rCOMM97e642832c6e: Makes fid optionally null so that we can delete the fid later

Summary

Whenever we set farcaster friends when connecting a new farcaster account, we want to clear previous farcaster entries to keep things up to date.
This means that fid should be optionally null so we can clear without deleting other auxUserStore fields.

Test Plan

dispatched setFarcasterFriendsFIDActionType with null and string fids and checked sqlite database that everything was stored properly

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Tue, Apr 16, 2:34 PM

Herald added a subscriber: tomek. · View Herald TranscriptTue, Apr 16, 2:34 PM

will added a child revision: D11639: [lib] Add farcaster friend fids to sqlite.Tue, Apr 16, 2:35 PM

Harbormaster completed remote builds in B28252: Diff 39163.Tue, Apr 16, 2:50 PM

will requested review of this revision.Tue, Apr 16, 2:50 PM

will added a child revision: D11672: create new aux user store action for clearing fids.Tue, Apr 16, 3:20 PM

will removed a child revision: D11639: [lib] Add farcaster friend fids to sqlite.Tue, Apr 16, 3:29 PM

ashoat accepted this revision.Wed, Apr 17, 6:30 AM

This revision is now accepted and ready to land.Wed, Apr 17, 6:30 AM

Closed by commit rCOMM97e642832c6e: Makes fid optionally null so that we can delete the fid later (authored by will). · Explain WhyThu, Apr 18, 9:13 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM97e642832c6e: Makes fid optionally null so that we can delete the fid later.

Revision Contents
Changeset List

Path

Size

lib/

types/

aux-user-types.js

2 lines

Diff 39266

lib/types/aux-user-types.js

Loading...