Paths

Table of Contentst

[lib] introduce fetchFollowedFarcasterChannels to neynar client class
ClosedPublic
Actions

Authored by ginsu on Apr 17 2024, 10:48 AM.

Details

Reviewers

atul
inka
ashoat

Commits

rCOMMb9c03cdb74fb: [lib] introduce fetchFollowedFarcasterChannels to neynar client class

Summary

fetchFollowedFarcasterChannels is a function that given a user fid will retrieve all channels that the user follows on farcaster

Endpoint reference in neynar docs: https://docs.neynar.com/reference/user-channels

Linear task: https://linear.app/comm/issue/ENG-7465/add-the-user-channels-neynar-endpoint-to-our-neynar-api-client

Depends on D11675

Test Plan

Passed in my personal fid and confirmed that the results I got from this function match exactly what is shown on warpcast

my channels I follow on warpcast:

Screenshot 2024-04-17 at 1.55.54 PM.png (1×470 px, 89 KB)

results of fetchFollowedFarcasterChannels (intentionally only logged the channel name to make it easy to view all the results):

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 17 2024, 10:48 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 17 2024, 10:48 AM

ginsu edited the summary of this revision. (Show Details)Apr 17 2024, 10:58 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added a parent revision: D11675: [lib] refine fetchFriendFIDs function.

ginsu added inline comments.

lib/utils/neynar-client.js
22–26 ↗	(On Diff #39187)	This type is a bit barebones atm, but figured we could always just extend this as we keep building

ginsu edited the summary of this revision. (Show Details)Apr 17 2024, 11:00 AM

ginsu added reviewers: atul, inka.

Harbormaster completed remote builds in B28266: Diff 39187.Apr 17 2024, 11:29 AM

ginsu requested review of this revision.Apr 17 2024, 11:29 AM

ashoat accepted this revision.Apr 17 2024, 3:29 PM

ashoat added inline comments.

lib/utils/neynar-client.js
107 ↗	(On Diff #39187)	I would just return `FarcasterChannel[]` here
140–142 ↗	(On Diff #39187)	`getMessageForException`

This revision is now accepted and ready to land.Apr 17 2024, 3:29 PM

address comments

Harbormaster completed remote builds in B28280: Diff 39204.Apr 17 2024, 10:24 PM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 18 2024, 7:55 AM

Closed by commit rCOMMb9c03cdb74fb: [lib] introduce fetchFollowedFarcasterChannels to neynar client class (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMb9c03cdb74fb: [lib] introduce fetchFollowedFarcasterChannels to neynar client class.

Harbormaster completed remote builds in B28296: Diff 39220.Apr 18 2024, 8:09 AM

ginsu mentioned this in D11689: [lib/web] fix error handling indirection.Apr 18 2024, 12:00 PM

ginsu mentioned this in rCOMMb0c7149f1f9c: [lib/web] fix error handling indirection.Apr 18 2024, 1:33 PM

Revision Contents
Changeset List

Path

Size

lib/

utils/

neynar-client.js

58 lines

Diff 39225

View Options

lib/utils/neynar-client.js

[lib] introduce fetchFollowedFarcasterChannels to neynar client classClosedPublicActions