[identity] make sure otk exists when we delete it
ClosedPublic
Actions

Authored by varun on Wed, Apr 17, 11:03 AM.

Details

Reviewers

Commits

rCOMMc4f179752442: [identity] make sure otk exists when we delete it

Summary

since DeleteItem is idempotent, we need to check that the key actually exists when we try deleting it, otherwise we'll be decrementing the otk count but not actually removing any otks

Test Plan

confirmed that if the key doesn't exist, the transaction fails

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Wed, Apr 17, 11:03 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Apr 17, 11:03 AM

Harbormaster completed remote builds in B28268: Diff 39189.Wed, Apr 17, 11:37 AM

varun requested review of this revision.Wed, Apr 17, 11:37 AM

varun added a parent revision: D11677: [identity] make sure we don't call refresh keys task twice when fetching content and notif keys.Wed, Apr 17, 8:54 PM

Theoretically, we should check if partition and sort key exist (because the otk attribute is present for all rows) but technically, this way also works - the "otk" attribute won't exist for non-existing row (implies non-existing primary key)

This revision is now accepted and ready to land.Thu, Apr 18, 12:15 AM

Closed by commit rCOMMc4f179752442: [identity] make sure otk exists when we delete it (authored by varun). · Explain WhyThu, Apr 18, 11:36 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMc4f179752442: [identity] make sure otk exists when we delete it.