Differential D11657

check one-time key format
ClosedPublic
Actions

Authored by varun on Apr 13 2024, 8:40 AM.

Details

Reviewers

bartek

Commits

rCOMMa6b05e1ac0c6: check one-time key format

Summary

make sure the one-time keys are not JSON strings and are 43 characters

Depends on D11608

Test Plan

commtest tests pass

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Apr 13 2024, 8:40 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 13 2024, 8:40 AM

Harbormaster completed remote builds in B28206: Diff 39096.Apr 13 2024, 8:58 AM

varun requested review of this revision.Apr 13 2024, 8:58 AM

varun added a child revision: D11658: [identity] check that prekeys are formatted correctly.Apr 13 2024, 11:40 AM

bartek accepted this revision.Apr 15 2024, 1:27 AM

This revision is now accepted and ready to land.Apr 15 2024, 1:27 AM

Closed by commit rCOMMa6b05e1ac0c6: check one-time key format (authored by varun). · Explain WhyApr 17 2024, 10:06 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMa6b05e1ac0c6: check one-time key format.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

identity/

olm_account_infos.rs

9 lines

tests/

identity_keyserver_tests.rs

14 lines

identity_one_time_key_tests.rs

8 lines

identity_tunnelbroker_tests.rs

7 lines

identity/

src/

1 line

10 lines

2 lines

1 line

9 lines

Diff 39180

View Options

services/commtest/src/identity/olm_account_infos.rs

View Options

services/commtest/tests/identity_keyserver_tests.rs

View Options

services/commtest/tests/identity_one_time_key_tests.rs

View Options

services/commtest/tests/identity_tunnelbroker_tests.rs

View Options

services/identity/src/constants.rs

View Options

services/identity/src/database.rs

View Options

services/identity/src/error.rs

View Options

services/identity/src/main.rs

View Options

services/identity/src/olm.rs

check one-time key formatClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39180

services/commtest/src/identity/olm_account_infos.rs

services/commtest/tests/identity_keyserver_tests.rs

services/commtest/tests/identity_one_time_key_tests.rs

services/commtest/tests/identity_tunnelbroker_tests.rs

services/identity/src/constants.rs

services/identity/src/database.rs

services/identity/src/error.rs

services/identity/src/main.rs

services/identity/src/olm.rs

check one-time key format
ClosedPublic
Actions

Revision Contents
Changeset List