Page MenuHomePhabricator
Differential D11685

[identity] Add device list timestamp verification
ClosedPublic
Actions

Authored by bartek on Apr 18 2024, 6:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 5:47 AM
Unknown Object (File)
Oct 12 2024, 4:16 PM
Unknown Object (File)
Oct 12 2024, 4:16 PM
Unknown Object (File)
Oct 12 2024, 4:16 PM
Unknown Object (File)
Oct 12 2024, 4:16 PM
Unknown Object (File)
Oct 12 2024, 4:15 PM
Unknown Object (File)
Sep 16 2024, 12:01 PM
Unknown Object (File)
Sep 14 2024, 9:13 PM
View All 49 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMM34d9d1efac30: [identity] Add device list timestamp verification
Summary
  • Updated transact_update_devicelist to accept input timestamp, instead of always generating new. It's still optional for Identity-managed device list updates
  • Added timestamp verification criteria according to the whitepaper
Test Plan
  • Manually called the UpdateDeviceListRPC with valid / invalid timestamps
  • Updated integration test (previously failing due to dummy timestamp)
  • Added unit tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Apr 18 2024, 6:15 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 18 2024, 6:15 AM
bartek added a child revision: D11686: [identity] Extract device list verification to separate func.Apr 18 2024, 6:15 AM
Harbormaster failed remote builds in B28291: Diff 39215!Apr 18 2024, 6:37 AM
bartek updated this revision to Diff 39268.Apr 19 2024, 2:33 AM

Fix commtest

Harbormaster completed remote builds in B28318: Diff 39268.Apr 19 2024, 2:55 AM
bartek edited the summary of this revision. (Show Details)Apr 19 2024, 3:28 AM
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Apr 19 2024, 3:30 AM
bartek added inline comments.
services/identity/src/constants.rs
168 ↗(On Diff #39268)

Value from whitepaper section 6.2.3

varun accepted this revision.Apr 22 2024, 2:35 PM
This revision is now accepted and ready to land.Apr 22 2024, 2:35 PM
Closed by commit rCOMM34d9d1efac30: [identity] Add device list timestamp verification (authored by bartek). · Explain WhyApr 25 2024, 12:37 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM34d9d1efac30: [identity] Add device list timestamp verification.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
4 lines
identity/
src/
4 lines
database/
37 lines
88 lines
1 line

Diff 39479

View Options

services/commtest/tests/identity_device_list_tests.rs

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/database/device_list.rs

Loading...
View Options

services/identity/src/device_list.rs

Loading...
View Options

services/identity/src/main.rs

Loading...