Updated device list validation logic. Added possibility to remove a device in UpdateDeviceList RPC.
Depends on D11686
Details
Details
Called the RPC with a few scenarios:
- Add one device - pass
- Add two devices - fails
- Remove one device - pass
- Remove two devices - fail
- Remove primary device - fail
- Both remove and add device - fail
- Keep list unchanged - fail
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/identity/src/device_list.rs | ||
|---|---|---|
| 89–91 ↗ | (On Diff #39270) | Currently, the UpdateDeviceList RPC is used only when adding or [soon] logging out a secondary device. We don't do primary device switch with this RPC so it shouldn't be able to do this operation. There's a reason - we're switching primary device only with Identity-managed device list updates because we need to do it in sync with updating social proof for ETH users. Otherwise, we could end up with having social proof for device that is no longer the primary one. |