Paths

Table of Contentst

[lib/web] fix error handling indirection
ClosedPublic
Actions

Authored by ginsu on Apr 18 2024, 12:00 PM.

Details

Reviewers

atul
varun
ashoat

Commits

rCOMMb0c7149f1f9c: [lib/web] fix error handling indirection

Summary

I didn't correctly address the feedback in D11675 + D11676 for the error handling misdirection. This diff should correctly address that feedback + fix the other cases in the codebase that followed this patern

Test Plan

flow + went over the use cases in identity-service-client-wrapper w/ @varun irl to confirm nothing would break

Diff Detail

Repository

rCOMM Comm

Branch

eng-7462 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 18 2024, 12:00 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 18 2024, 12:00 PM

ginsu added reviewers: atul, varun, ashoat.Apr 18 2024, 12:01 PM

Harbormaster completed remote builds in B28299: Diff 39236.Apr 18 2024, 12:16 PM

ginsu requested review of this revision.Apr 18 2024, 12:16 PM

ginsu edited the test plan for this revision. (Show Details)Apr 18 2024, 12:17 PM

ginsu added 1 blocking reviewer(s): varun.

Looks good!

varun accepted this revision.Apr 18 2024, 12:24 PM

This revision is now accepted and ready to land.Apr 18 2024, 12:24 PM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 18 2024, 1:33 PM

Closed by commit rCOMMb0c7149f1f9c: [lib/web] fix error handling indirection (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMb0c7149f1f9c: [lib/web] fix error handling indirection.

Harbormaster completed remote builds in B28313: Diff 39260.Apr 18 2024, 2:17 PM

Revision Contents
Changeset List

Path

Size

lib/

utils/

neynar-client.js

14 lines

web/

grpc/

identity-service-client-wrapper.js

35 lines

Diff 39236

View Options

lib/utils/neynar-client.js