Paths

Table of Contentst

[CommRustModule] add JSI bindings for `GetDeviceListsForUsers` RPC
ClosedPublic
Actions

Authored by kamil on Apr 29 2024, 2:46 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMMd99a38aefea7: [CommRustModule] add JSI bindings for `GetDeviceListsForUsers` RPC

Summary

Exposed the GetDeviceListsForUsers to JS - added it to CommRustModule

Depends on D11832

Test Plan

Tested in D11834

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 29 2024, 2:46 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 29 2024, 2:46 PM

kamil added a child revision: D11834: [native] add `GetDeviceListsForUsers` in `IdentityServiceClient`.Apr 29 2024, 2:58 PM

kamil edited the test plan for this revision. (Show Details)Apr 29 2024, 2:59 PM

Harbormaster completed remote builds in B28578: Diff 39658.Apr 29 2024, 3:05 PM

kamil published this revision for review.Apr 29 2024, 3:50 PM

tomek accepted this revision.Apr 30 2024, 8:48 AM

This revision is now accepted and ready to land.Apr 30 2024, 8:48 AM

Closed by commit rCOMMd99a38aefea7: [CommRustModule] add JSI bindings for `GetDeviceListsForUsers` RPC. · Explain WhyApr 30 2024, 10:23 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMd99a38aefea7: [CommRustModule] add JSI bindings for `GetDeviceListsForUsers` RPC.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommRustModule.h

6 lines

CommRustModule.cpp

33 lines

_generated/

rustJSI-generated.cpp

rustJSI.h

schema/

CommRustModuleSchema.js

6 lines

Diff 39689

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI.h

View Options

native/schema/CommRustModuleSchema.js

[CommRustModule] add JSI bindings for `GetDeviceListsForUsers` RPCClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39689

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/schema/CommRustModuleSchema.js

[CommRustModule] add JSI bindings for `GetDeviceListsForUsers` RPC
ClosedPublic
Actions

Revision Contents
Changeset List