Page MenuHomePhabricator
Differential D11835

[web] add `GetDeviceListsForUsers` in `IdentityServiceClient`
ClosedPublic
Actions

Authored by kamil on Mon, Apr 29, 8:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 5:58 AM
Unknown Object (File)
Tue, May 7, 6:41 PM
Unknown Object (File)
Mon, May 6, 6:52 PM
Unknown Object (File)
Sun, May 5, 7:18 PM
Unknown Object (File)
Sun, May 5, 3:38 PM
Unknown Object (File)
Sun, May 5, 9:16 AM
Unknown Object (File)
Sat, May 4, 7:33 AM
Unknown Object (File)
Fri, May 3, 4:56 PM
View All 11 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMMfd94c324c7e0: [web] add `GetDeviceListsForUsers` in `IdentityServiceClient`
Summary

JS implementation of GetDeviceListsForUsers RPC

Depends on D11834

Test Plan

Call this method for multiple user and test if it works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Apr 29, 8:02 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMon, Apr 29, 8:02 AM
Harbormaster completed remote builds in B28580: Diff 39660.Mon, Apr 29, 8:19 AM
kamil published this revision for review.Mon, Apr 29, 8:51 AM
tomek accepted this revision.Tue, Apr 30, 1:54 AM
tomek added inline comments.
web/grpc/identity-service-client-wrapper.js
548–556 ↗(On Diff #39660)

This can be simplified using _.mapValues - but up to you.

This revision is now accepted and ready to land.Tue, Apr 30, 1:54 AM
kamil added inline comments.Tue, Apr 30, 2:57 AM
web/grpc/identity-service-client-wrapper.js
548–556 ↗(On Diff #39660)

We used a similar approach in this file (and the native version of it) so I prefer to stick to it.
Also, my personal opinion is that with mapValues we gain a bit shorter code but a lot less readable.

kamil updated this revision to Diff 39686.Tue, Apr 30, 2:58 AM

rebase before landing

Harbormaster completed remote builds in B28598: Diff 39686.Tue, Apr 30, 3:13 AM
Closed by commit rCOMMfd94c324c7e0: [web] add `GetDeviceListsForUsers` in `IdentityServiceClient` (authored by kamil). · Explain WhyTue, Apr 30, 3:23 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMfd94c324c7e0: [web] add `GetDeviceListsForUsers` in `IdentityServiceClient`.

Revision Contents
Changeset List

Diff 39690

View Options

lib/types/identity-service-types.js

Loading...
View Options

web/grpc/identity-service-client-wrapper.js

Loading...
View Options

web/grpc/identity-service-context-provider.react.js

Loading...