Page MenuHomePhabricator
Differential D11835

[web] add `GetDeviceListsForUsers` in `IdentityServiceClient`
ClosedPublic
Actions

Authored by kamil on Apr 29 2024, 8:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 10:10 AM
Unknown Object (File)
Tue, Nov 12, 9:28 AM
Unknown Object (File)
Tue, Nov 12, 8:56 AM
Unknown Object (File)
Tue, Nov 12, 8:16 AM
Unknown Object (File)
Tue, Nov 12, 1:30 AM
Unknown Object (File)
Mon, Nov 11, 2:24 PM
Unknown Object (File)
Sun, Oct 27, 4:18 AM
Unknown Object (File)
Thu, Oct 24, 8:05 PM
View All 72 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMMfd94c324c7e0: [web] add `GetDeviceListsForUsers` in `IdentityServiceClient`
Summary

JS implementation of GetDeviceListsForUsers RPC

Depends on D11834

Test Plan

Call this method for multiple user and test if it works

Diff Detail

Repository
rCOMM Comm
Branch
init-peer-list
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Apr 29 2024, 8:02 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptApr 29 2024, 8:02 AM
Harbormaster completed remote builds in B28580: Diff 39660.Apr 29 2024, 8:19 AM
kamil published this revision for review.Apr 29 2024, 8:51 AM
tomek accepted this revision.Apr 30 2024, 1:54 AM
tomek added inline comments.
web/grpc/identity-service-client-wrapper.js
548–556 ↗(On Diff #39660)

This can be simplified using _.mapValues - but up to you.

This revision is now accepted and ready to land.Apr 30 2024, 1:54 AM
kamil added inline comments.Apr 30 2024, 2:57 AM
web/grpc/identity-service-client-wrapper.js
548–556 ↗(On Diff #39660)

We used a similar approach in this file (and the native version of it) so I prefer to stick to it.
Also, my personal opinion is that with mapValues we gain a bit shorter code but a lot less readable.

kamil updated this revision to Diff 39686.Apr 30 2024, 2:58 AM

rebase before landing

Harbormaster completed remote builds in B28598: Diff 39686.Apr 30 2024, 3:13 AM
Closed by commit rCOMMfd94c324c7e0: [web] add `GetDeviceListsForUsers` in `IdentityServiceClient` (authored by kamil). · Explain WhyApr 30 2024, 3:23 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMfd94c324c7e0: [web] add `GetDeviceListsForUsers` in `IdentityServiceClient`.

Revision Contents
Changeset List

Diff 39686

View Options

lib/types/identity-service-types.js

Loading...
View Options

web/grpc/identity-service-client-wrapper.js

Loading...
View Options

web/grpc/identity-service-context-provider.react.js

Loading...