[CryptoModule] remove `(char *)` casting
ClosedPublic
Actions

Authored by kamil on Apr 29 2024, 9:11 AM.

Tags

None

Referenced Files

	F3301028: D11836.id39661.diff
	Sun, Nov 17, 11:24 PM

	Unknown Object (File)
	Tue, Nov 12, 4:26 AM

	Unknown Object (File)
	Tue, Nov 12, 2:45 AM

	Unknown Object (File)
	Mon, Nov 11, 10:05 PM

	Unknown Object (File)
	Mon, Nov 11, 4:41 PM

	Unknown Object (File)
	Sat, Nov 9, 5:44 AM

	Unknown Object (File)
	Fri, Oct 25, 6:46 AM

	Unknown Object (File)
	Mon, Oct 21, 2:55 AM

View All 51 Files

Subscribers

ashoat

tomek

Details

Reviewers

marcin

Commits

rCOMM411a2456aa6b: [CryptoModule] remove `(char *)` casting

Summary

This addresses https://phab.comm.dev/D11717#inline-70373

Test Plan

being able to decrypt message

Diff Detail

Repository

rCOMM Comm

Branch

decrypt-improvements

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Apr 29 2024, 9:11 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 29 2024, 9:11 AM

kamil mentioned this in D11717: [CryptoModule] add sequential decrypt to crypto API.Apr 29 2024, 9:12 AM

kamil published this revision for review.Apr 29 2024, 9:24 AM

Harbormaster completed remote builds in B28581: Diff 39661.Apr 29 2024, 9:28 AM

marcin accepted this revision.May 6 2024, 3:37 AM

This revision is now accepted and ready to land.May 6 2024, 3:37 AM

Closed by commit rCOMM411a2456aa6b: [CryptoModule] remove `(char *)` casting (authored by kamil). · Explain WhyMay 6 2024, 4:23 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM411a2456aa6b: [CryptoModule] remove `(char *)` casting.

marcin added a reverting change: rCOMM3d71d5afcc79: Revert "[CryptoModule] remove `(char *)` casting".May 20 2024, 8:27 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

CryptoTools/

Session.cpp

4 lines

Diff 39661

View Options

native/cpp/CommonCpp/CryptoTools/Session.cpp

[CryptoModule] remove `(char *)` castingClosedPublicActions