Page MenuHomePhabricator

[CryptoModule] add sequential decrypt to crypto API
ClosedPublic

Authored by kamil on Apr 22 2024, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 23, 7:24 PM
Unknown Object (File)
Wed, Oct 23, 7:24 PM
Unknown Object (File)
Wed, Oct 23, 7:24 PM
Unknown Object (File)
Wed, Oct 23, 7:21 PM
Unknown Object (File)
Fri, Oct 18, 10:29 PM
Unknown Object (File)
Tue, Oct 15, 2:30 PM
Unknown Object (File)
Wed, Oct 9, 6:16 PM
Unknown Object (File)
Wed, Oct 9, 4:18 AM
Subscribers

Details

Summary

This adds wrapper to olm method to sequential decrypt added in PR#11.

Test Plan

Tested in next diff in the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
native/cpp/CommonCpp/CryptoTools/Session.cpp
160 ↗(On Diff #39368)

there is some code duplication but not sure if there is a cleaner way of deduplicating this

kamil published this revision for review.Apr 23 2024, 6:37 AM
native/cpp/CommonCpp/CryptoTools/Session.cpp
160 ↗(On Diff #39368)

Could we extract it to a common function that returns length for decrypted content buffer? This particular example seems to be too much duplication.

202 ↗(On Diff #39368)

I think it wouldn't hurt to replace it with constructor that doesn't require casting:

std::string{decryptedMessage.begin(), decryptedMessage.end()};
This revision is now accepted and ready to land.Apr 24 2024, 3:04 AM

I missed @marcin's inline comments - I'll put up a diff shortly

native/cpp/CommonCpp/CryptoTools/Session.cpp
160 ↗(On Diff #39368)

not sure about it - this function will only call olm_decrypt_max_plaintext_length which is weird because it's like creating a wrapper over direct olm function call

202 ↗(On Diff #39368)