Page MenuHomePhabricator

[CommCoreModule] add sequential decrypt to crypto API
ClosedPublic

Authored by kamil on Apr 22 2024, 3:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 1:34 PM
Unknown Object (File)
Fri, Nov 8, 5:12 PM
Unknown Object (File)
Fri, Oct 25, 12:58 AM
Unknown Object (File)
Wed, Oct 23, 7:24 PM
Unknown Object (File)
Wed, Oct 23, 7:24 PM
Unknown Object (File)
Wed, Oct 23, 7:21 PM
Unknown Object (File)
Sep 22 2024, 3:41 AM
Unknown Object (File)
Sep 20 2024, 2:03 PM
Subscribers

Details

Summary

Binding to olm method to sequential decrypt. Implementing different because this method will also be responsible for persisting message in SQLite (added later in the stack).

Depends on D11717

Test Plan

Created session between two native clients:

  1. Sending couple of encrypted messsages
  2. Sending messages with wrong order -> OLM_MESSAGE_OUT_OF_ORDER
  3. Sending the same message multiple times -> OLM_ALREADY_DECRYPTED_OR_KEYS_SKIPPED

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
1374 ↗(On Diff #39369)

not used yet but this is needed to persist message - added later in the stack

kamil published this revision for review.Apr 23 2024, 6:37 AM
marcin added inline comments.
web/cpp/SQLiteQueryExecutorBindings.cpp
65 ↗(On Diff #39369)

Looks like someone accidentally forgot to run yarn clang-format-all. Ideally we could fix it so that it is automatically run on as a commit hook.

This revision is now accepted and ready to land.Apr 24 2024, 3:09 AM
web/cpp/SQLiteQueryExecutorBindings.cpp
65 ↗(On Diff #39369)