[CommCoreModule] add sequential decrypt to crypto API
ClosedPublic
Actions

Authored by kamil on Mon, Apr 22, 3:32 PM.

Details

Reviewers

tomek
marcin

Commits

rCOMM5614c6e730ac: [CommCoreModule] add sequential decrypt to crypto API

Summary

Binding to olm method to sequential decrypt. Implementing different because this method will also be responsible for persisting message in SQLite (added later in the stack).

Depends on D11717

Test Plan

Created session between two native clients:

Sending couple of encrypted messsages
Sending messages with wrong order -> OLM_MESSAGE_OUT_OF_ORDER
Sending the same message multiple times -> OLM_ALREADY_DECRYPTED_OR_KEYS_SKIPPED

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Apr 22, 3:32 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMon, Apr 22, 3:32 PM

kamil added inline comments.Mon, Apr 22, 3:35 PM

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
1374 ↗	(On Diff #39369)	not used yet but this is needed to persist message - added later in the stack

kamil added a child revision: D11719: [web/lib] add sequential decrypt to `olmAPI`.Mon, Apr 22, 3:42 PM

Harbormaster completed remote builds in B28375: Diff 39369.Mon, Apr 22, 3:51 PM

kamil published this revision for review.Tue, Apr 23, 6:37 AM

marcin accepted this revision.Wed, Apr 24, 3:09 AM

marcin added inline comments.

web/cpp/SQLiteQueryExecutorBindings.cpp
65 ↗	(On Diff #39369)	Looks like someone accidentally forgot to run `yarn clang-format-all`. Ideally we could fix it so that it is automatically run on as a commit hook.