[native/web] add SQL transaction to persisting crypto module
ClosedPublic
Actions

Authored by kamil on Apr 22 2024, 4:01 PM.

Details

Reviewers

tomek
marcin

Commits

rCOMMdca857f6ff67: [native/web] add SQL transaction to persisting crypto module

Summary

Not sure why there was no transaction here, but I think it's better to add this. Mostly because it implies more than one operation (persisting two accounts in two separate calls).

Wondering what @marcin thinks about this change.

Depends on D11720

Test Plan

Play a bit with crypto-related API to make sure it still works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 22 2024, 4:01 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 22 2024, 4:01 PM

Harbormaster completed remote builds in B28378: Diff 39372.Apr 22 2024, 4:17 PM

kamil added a child revision: D11727: [CommCoreModule] decrypt and persist plaintext in SQL transaction.Apr 22 2024, 5:18 PM

kamil edited the summary of this revision. (Show Details)Apr 23 2024, 5:31 AM

kamil published this revision for review.Apr 23 2024, 6:38 AM

I think it is good to add a transaction here as it will force accounts states in SQLite to be in sync.

marcin accepted this revision.Apr 24 2024, 3:21 AM

This revision is now accepted and ready to land.Apr 24 2024, 3:21 AM

rebase before landing

Harbormaster completed remote builds in B28557: Diff 39614.Apr 29 2024, 1:07 AM

Closed by commit rCOMMdca857f6ff67: [native/web] add SQL transaction to persisting crypto module (authored by kamil). · Explain WhyApr 29 2024, 1:11 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMdca857f6ff67: [native/web] add SQL transaction to persisting crypto module.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

3 lines

web/

shared-worker/

worker/

worker-crypto.js

3 lines

Diff 39619

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show First 20 Lines • Show All 131 Lines • ▼ Show 20 Lines	try {
]);		]);
} catch {}		} catch {}
const currentUserInfo = response ? loggedOutUserInfo : null;		const currentUserInfo = response ? loggedOutUserInfo : null;
return { currentUserInfo, preRequestUserState, keyserverIDs };		return { currentUserInfo, preRequestUserState, keyserverIDs };
};		};

type UseLogOutOptions = {		type UseLogOutOptions = {
+logOutType?: 'legacy' \| 'primary_device' \| 'secondary_device',		+logOutType?: 'legacy' \| 'primary_device' \| 'secondary_device',
		+skipIdentityLogOut?: boolean,
};		};

function useLogOut(		function useLogOut(
options: UseLogOutOptions = {},		options: UseLogOutOptions = {},
): (keyserverIDs?: $ReadOnlyArray<string>) => Promise<LogOutResult> {		): (keyserverIDs?: $ReadOnlyArray<string>) => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;		const identityClient = client?.identityClient;

const preRequestUserState = usePreRequestUserState();		const preRequestUserState = usePreRequestUserState();
const callKeyserverLogOut = useKeyserverCall(keyserverLogOut);		const callKeyserverLogOut = useKeyserverCall(keyserverLogOut);

const commServicesAccessToken = useSelector(		const commServicesAccessToken = useSelector(
state => state.commServicesAccessToken,		state => state.commServicesAccessToken,
);		);

const { logOutType } = options;		const { logOutType, skipIdentityLogOut } = options;
return React.useCallback(		return React.useCallback(
async (keyserverIDs?: $ReadOnlyArray<string>) => {		async (keyserverIDs?: $ReadOnlyArray<string>) => {
const identityPromise = (async () => {		const identityPromise = (async () => {
if (!usingCommServicesAccessToken \|\| !commServicesAccessToken) {		if (
		skipIdentityLogOut \|\|
		!usingCommServicesAccessToken \|\|
		!commServicesAccessToken
		) {
return;		return;
}		}
if (!identityClient) {		if (!identityClient) {
throw new Error('Identity service client is not initialized');		throw new Error('Identity service client is not initialized');
}		}
let callIdentityClientLogOut;		let callIdentityClientLogOut;
if (logOutType === 'primary_device') {		if (logOutType === 'primary_device') {
if (!identityClient.logOutPrimaryDevice) {		if (!identityClient.logOutPrimaryDevice) {
Show All 36 Lines	async (keyserverIDs?: $ReadOnlyArray<string>) => {
};		};
},		},
[		[
callKeyserverLogOut,		callKeyserverLogOut,
commServicesAccessToken,		commServicesAccessToken,
identityClient,		identityClient,
logOutType,		logOutType,
preRequestUserState,		preRequestUserState,
		skipIdentityLogOut,
],		],
);		);
}		}

function useIdentityLogOut(): () => Promise<LogOutResult> {		function useIdentityLogOut(): () => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;		const identityClient = client?.identityClient;

▲ Show 20 Lines • Show All 1,230 Lines • Show Last 20 Lines