[native/web] add SQL transaction to persisting crypto module
ClosedPublic
Actions

Authored by kamil on Apr 22 2024, 4:01 PM.

Details

Reviewers

tomek
marcin

Commits

rCOMMdca857f6ff67: [native/web] add SQL transaction to persisting crypto module

Summary

Not sure why there was no transaction here, but I think it's better to add this. Mostly because it implies more than one operation (persisting two accounts in two separate calls).

Wondering what @marcin thinks about this change.

Depends on D11720

Test Plan

Play a bit with crypto-related API to make sure it still works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 22 2024, 4:01 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 22 2024, 4:01 PM

Harbormaster completed remote builds in B28378: Diff 39372.Apr 22 2024, 4:17 PM

kamil added a child revision: D11727: [CommCoreModule] decrypt and persist plaintext in SQL transaction.Apr 22 2024, 5:18 PM

kamil edited the summary of this revision. (Show Details)Apr 23 2024, 5:31 AM

kamil published this revision for review.Apr 23 2024, 6:38 AM

I think it is good to add a transaction here as it will force accounts states in SQLite to be in sync.

marcin accepted this revision.Apr 24 2024, 3:21 AM

This revision is now accepted and ready to land.Apr 24 2024, 3:21 AM

rebase before landing

Harbormaster completed remote builds in B28557: Diff 39614.Apr 29 2024, 1:07 AM

Closed by commit rCOMMdca857f6ff67: [native/web] add SQL transaction to persisting crypto module (authored by kamil). · Explain WhyApr 29 2024, 1:11 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMdca857f6ff67: [native/web] add SQL transaction to persisting crypto module.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

3 lines

web/

shared-worker/

worker/

worker-crypto.js

3 lines

Diff 39619

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show All 19 Lines	export const siweBackupDataValidator: TInterface<SIWEBackupData> =
});		});

// This type should match `LatestBackupInfo` in		// This type should match `LatestBackupInfo` in
// `native/native_rust_library/src/backup.rs`		// `native/native_rust_library/src/backup.rs`
export type LatestBackupInfo = {		export type LatestBackupInfo = {
+backupID: string,		+backupID: string,
+userID: string,		+userID: string,
+siweBackupData?: ?SIWEBackupData,		+siweBackupData?: ?SIWEBackupData,
		+keyserverDeviceID?: ?string,
};		};
export const latestBackupInfoResponseValidator: TInterface<LatestBackupInfo> =		export const latestBackupInfoResponseValidator: TInterface<LatestBackupInfo> =
tShape<LatestBackupInfo>({		tShape<LatestBackupInfo>({
backupID: t.String,		backupID: t.String,
userID: t.String,		userID: t.String,
siweBackupData: t.maybe(siweBackupDataValidator),		siweBackupData: t.maybe(siweBackupDataValidator),
		keyserverDeviceID: t.maybe(t.String),
});		});

// This type should match `UserKeys` in		// This type should match `UserKeys` in
// `native/native_rust_library/src/backup.rs`		// `native/native_rust_library/src/backup.rs`
export type UserKeys = {		export type UserKeys = {
+backupDataKey: string,		+backupDataKey: string,
+backupLogDataKey: string,		+backupLogDataKey: string,
+pickleKey: string,		+pickleKey: string,
Show All 19 Lines