Page MenuHomePhabricator
Differential D11721

[native/web] add SQL transaction to persisting crypto module
ClosedPublic
Actions

Authored by kamil on Mon, Apr 22, 4:01 PM.
Tags
None
Referenced Files
F1696510: D11721.id39614.diff
Fri, May 3, 1:37 PM
F1693503: D11721.id39372.diff
Thu, May 2, 3:47 PM
F1693411: D11721.id.diff
Thu, May 2, 3:26 PM
Unknown Object (File)
Sun, Apr 28, 4:17 PM
Unknown Object (File)
Fri, Apr 26, 7:59 PM
Unknown Object (File)
Fri, Apr 26, 1:27 PM
Unknown Object (File)
Tue, Apr 23, 1:50 AM
Unknown Object (File)
Tue, Apr 23, 1:49 AM
View All 9 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMMdca857f6ff67: [native/web] add SQL transaction to persisting crypto module
Summary

Not sure why there was no transaction here, but I think it's better to add this. Mostly because it implies more than one operation (persisting two accounts in two separate calls).

Wondering what @marcin thinks about this change.

Depends on D11720

Test Plan

Play a bit with crypto-related API to make sure it still works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Apr 22, 4:01 PM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMon, Apr 22, 4:01 PM
Harbormaster completed remote builds in B28378: Diff 39372.Mon, Apr 22, 4:17 PM
kamil added a child revision: D11727: [CommCoreModule] decrypt and persist plaintext in SQL transaction.Mon, Apr 22, 5:18 PM
kamil edited the summary of this revision. (Show Details)Tue, Apr 23, 5:31 AM
kamil published this revision for review.Tue, Apr 23, 6:38 AM
marcin added a comment.Wed, Apr 24, 3:21 AM

I think it is good to add a transaction here as it will force accounts states in SQLite to be in sync.

marcin accepted this revision.Wed, Apr 24, 3:21 AM
This revision is now accepted and ready to land.Wed, Apr 24, 3:21 AM
kamil updated this revision to Diff 39614.Mon, Apr 29, 12:51 AM

rebase before landing

Harbormaster completed remote builds in B28557: Diff 39614.Mon, Apr 29, 1:07 AM
Closed by commit rCOMMdca857f6ff67: [native/web] add SQL transaction to persisting crypto module (authored by kamil). · Explain WhyMon, Apr 29, 1:11 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMdca857f6ff67: [native/web] add SQL transaction to persisting crypto module.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
3 lines
web/
shared-worker/
worker/
3 lines

Diff 39619

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

web/shared-worker/worker/worker-crypto.js

Loading...