Page MenuHomePhabricator
Differential D11720

[lib] update P2P message handler to use sequential decrypt
ClosedPublic
Actions

Authored by kamil on Apr 22 2024, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 10:32 AM
Unknown Object (File)
Thu, Apr 17, 2:56 AM
Unknown Object (File)
Thu, Apr 17, 1:42 AM
Unknown Object (File)
Thu, Apr 17, 12:13 AM
Unknown Object (File)
Wed, Apr 16, 7:16 AM
Unknown Object (File)
Wed, Apr 9, 11:26 AM
Unknown Object (File)
Mon, Mar 24, 4:09 PM
Unknown Object (File)
Mar 6 2025, 10:20 PM
View All 75 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMM9c2c1d2788de: [lib] update P2P message handler to use sequential decrypt
Summary

In client <-> client communication we have to track messages order.

Depends on D11719

Test Plan

Created session between two clients:

  1. Sending a couple of encrypted messages
  2. Sending messages with wrong order -> OLM_MESSAGE_OUT_OF_ORDER
  3. Sending the same message multiple times -> OLM_ALREADY_DECRYPTED_OR_KEYS_SKIPPED

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Apr 22 2024, 3:53 PM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptApr 22 2024, 3:53 PM
kamil retitled this revision from [lib]update P2P message handler to use sequential decrypt to [lib] update P2P message handler to use sequential decrypt.Apr 22 2024, 3:54 PM
kamil added a child revision: D11721: [native/web] add SQL transaction to persisting crypto module.Apr 22 2024, 4:01 PM
Harbormaster completed remote builds in B28377: Diff 39371.Apr 22 2024, 4:08 PM
kamil added inline comments.Apr 23 2024, 5:29 AM
lib/utils/olm-utils.js
127 ↗(On Diff #39371)
kamil published this revision for review.Apr 23 2024, 6:38 AM
marcin accepted this revision.Apr 24 2024, 3:12 AM
This revision is now accepted and ready to land.Apr 24 2024, 3:12 AM
kamil updated this revision to Diff 39613.Apr 29 2024, 12:51 AM

update comment

Harbormaster completed remote builds in B28556: Diff 39613.Apr 29 2024, 1:06 AM
Closed by commit rCOMM9c2c1d2788de: [lib] update P2P message handler to use sequential decrypt (authored by kamil). · Explain WhyApr 29 2024, 1:11 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM9c2c1d2788de: [lib] update P2P message handler to use sequential decrypt.

Revision Contents
Changeset List

PathSize
lib/
handlers/
24 lines
tunnelbroker/
6 lines
utils/
6 lines

Diff 39618

View Options

lib/handlers/peer-to-peer-message-handler.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { useENSNames } from 'lib/hooks/ens-cache.js';
import { useResettingState } from 'lib/hooks/use-resetting-state.js'; import { useResettingState } from 'lib/hooks/use-resetting-state.js';
import type { import type {
ChatMessageInfoItem, ChatMessageInfoItem,
ReactionInfo, ReactionInfo,
} from 'lib/selectors/chat-selectors.js'; } from 'lib/selectors/chat-selectors.js';
import { useCanEditMessage } from 'lib/shared/edit-messages-utils.js'; import { useCanEditMessage } from 'lib/shared/edit-messages-utils.js';
import { createMessageReply } from 'lib/shared/message-utils.js'; import { createMessageReply } from 'lib/shared/message-utils.js';
import { useCanCreateReactionFromMessage } from 'lib/shared/reaction-utils.js'; import { useCanCreateReactionFromMessage } from 'lib/shared/reaction-utils.js';
▲ Show 20 Lines • Show All 419 Lines • ▼ Show 20 Linesfunction useMessageTooltip({
}); });
return { return {
onMouseEnter, onMouseEnter,
onMouseLeave, onMouseLeave,
}; };
} }
const useENSNamesOptions = { allAtOnce: true };
type UseReactionTooltipArgs = { type UseReactionTooltipArgs = {
+reaction: string, +reaction: string,
+reactions: ReactionInfo, +reactions: ReactionInfo,
+availablePositions: $ReadOnlyArray<TooltipPosition>, +availablePositions: $ReadOnlyArray<TooltipPosition>,
}; };
function useReactionTooltip({ function useReactionTooltip({
reaction, reaction,
reactions, reactions,
availablePositions, availablePositions,
}: UseReactionTooltipArgs): UseTooltipResult { }: UseReactionTooltipArgs): UseTooltipResult {
const { users } = reactions[reaction]; const { users } = reactions[reaction];
const resolvedUsers = useENSNames(users, useENSNamesOptions);
const tooltipSize = React.useMemo(() => { const tooltipSize = React.useMemo(() => {
if (typeof document === 'undefined') { if (typeof document === 'undefined') {
return undefinedTooltipSize; return undefinedTooltipSize;
} }
const usernames = users.map(user => user.username).filter(Boolean); const usernames = resolvedUsers.map(user => user.username).filter(Boolean);
return calculateReactionTooltipSize(usernames); return calculateReactionTooltipSize(usernames);
}, [users]); }, [resolvedUsers]);
const createReactionTooltip = React.useCallback( const createReactionTooltip = React.useCallback(
() => <ReactionTooltip reactions={reactions} reaction={reaction} />, () => <ReactionTooltip reactions={reactions} reaction={reaction} />,
[reaction, reactions], [reaction, reactions],
); );
const { onMouseEnter, onMouseLeave } = useTooltip({ const { onMouseEnter, onMouseLeave } = useTooltip({
createTooltip: createReactionTooltip, createTooltip: createReactionTooltip,
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines
View Options

lib/tunnelbroker/tunnelbroker-context.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { useENSNames } from 'lib/hooks/ens-cache.js';
import { useResettingState } from 'lib/hooks/use-resetting-state.js'; import { useResettingState } from 'lib/hooks/use-resetting-state.js';
import type { import type {
ChatMessageInfoItem, ChatMessageInfoItem,
ReactionInfo, ReactionInfo,
} from 'lib/selectors/chat-selectors.js'; } from 'lib/selectors/chat-selectors.js';
import { useCanEditMessage } from 'lib/shared/edit-messages-utils.js'; import { useCanEditMessage } from 'lib/shared/edit-messages-utils.js';
import { createMessageReply } from 'lib/shared/message-utils.js'; import { createMessageReply } from 'lib/shared/message-utils.js';
import { useCanCreateReactionFromMessage } from 'lib/shared/reaction-utils.js'; import { useCanCreateReactionFromMessage } from 'lib/shared/reaction-utils.js';
▲ Show 20 Lines • Show All 419 Lines • ▼ Show 20 Linesfunction useMessageTooltip({
}); });
return { return {
onMouseEnter, onMouseEnter,
onMouseLeave, onMouseLeave,
}; };
} }
const useENSNamesOptions = { allAtOnce: true };
type UseReactionTooltipArgs = { type UseReactionTooltipArgs = {
+reaction: string, +reaction: string,
+reactions: ReactionInfo, +reactions: ReactionInfo,
+availablePositions: $ReadOnlyArray<TooltipPosition>, +availablePositions: $ReadOnlyArray<TooltipPosition>,
}; };
function useReactionTooltip({ function useReactionTooltip({
reaction, reaction,
reactions, reactions,
availablePositions, availablePositions,
}: UseReactionTooltipArgs): UseTooltipResult { }: UseReactionTooltipArgs): UseTooltipResult {
const { users } = reactions[reaction]; const { users } = reactions[reaction];
const resolvedUsers = useENSNames(users, useENSNamesOptions);
const tooltipSize = React.useMemo(() => { const tooltipSize = React.useMemo(() => {
if (typeof document === 'undefined') { if (typeof document === 'undefined') {
return undefinedTooltipSize; return undefinedTooltipSize;
} }
const usernames = users.map(user => user.username).filter(Boolean); const usernames = resolvedUsers.map(user => user.username).filter(Boolean);
return calculateReactionTooltipSize(usernames); return calculateReactionTooltipSize(usernames);
}, [users]); }, [resolvedUsers]);
const createReactionTooltip = React.useCallback( const createReactionTooltip = React.useCallback(
() => <ReactionTooltip reactions={reactions} reaction={reaction} />, () => <ReactionTooltip reactions={reactions} reaction={reaction} />,
[reaction, reactions], [reaction, reactions],
); );
const { onMouseEnter, onMouseLeave } = useTooltip({ const { onMouseEnter, onMouseLeave } = useTooltip({
createTooltip: createReactionTooltip, createTooltip: createReactionTooltip,
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines
View Options

lib/utils/olm-utils.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { useENSNames } from 'lib/hooks/ens-cache.js';
import { useResettingState } from 'lib/hooks/use-resetting-state.js'; import { useResettingState } from 'lib/hooks/use-resetting-state.js';
import type { import type {
ChatMessageInfoItem, ChatMessageInfoItem,
ReactionInfo, ReactionInfo,
} from 'lib/selectors/chat-selectors.js'; } from 'lib/selectors/chat-selectors.js';
import { useCanEditMessage } from 'lib/shared/edit-messages-utils.js'; import { useCanEditMessage } from 'lib/shared/edit-messages-utils.js';
import { createMessageReply } from 'lib/shared/message-utils.js'; import { createMessageReply } from 'lib/shared/message-utils.js';
import { useCanCreateReactionFromMessage } from 'lib/shared/reaction-utils.js'; import { useCanCreateReactionFromMessage } from 'lib/shared/reaction-utils.js';
▲ Show 20 Lines • Show All 419 Lines • ▼ Show 20 Linesfunction useMessageTooltip({
}); });
return { return {
onMouseEnter, onMouseEnter,
onMouseLeave, onMouseLeave,
}; };
} }
const useENSNamesOptions = { allAtOnce: true };
type UseReactionTooltipArgs = { type UseReactionTooltipArgs = {
+reaction: string, +reaction: string,
+reactions: ReactionInfo, +reactions: ReactionInfo,
+availablePositions: $ReadOnlyArray<TooltipPosition>, +availablePositions: $ReadOnlyArray<TooltipPosition>,
}; };
function useReactionTooltip({ function useReactionTooltip({
reaction, reaction,
reactions, reactions,
availablePositions, availablePositions,
}: UseReactionTooltipArgs): UseTooltipResult { }: UseReactionTooltipArgs): UseTooltipResult {
const { users } = reactions[reaction]; const { users } = reactions[reaction];
const resolvedUsers = useENSNames(users, useENSNamesOptions);
const tooltipSize = React.useMemo(() => { const tooltipSize = React.useMemo(() => {
if (typeof document === 'undefined') { if (typeof document === 'undefined') {
return undefinedTooltipSize; return undefinedTooltipSize;
} }
const usernames = users.map(user => user.username).filter(Boolean); const usernames = resolvedUsers.map(user => user.username).filter(Boolean);
return calculateReactionTooltipSize(usernames); return calculateReactionTooltipSize(usernames);
}, [users]); }, [resolvedUsers]);
const createReactionTooltip = React.useCallback( const createReactionTooltip = React.useCallback(
() => <ReactionTooltip reactions={reactions} reaction={reaction} />, () => <ReactionTooltip reactions={reactions} reaction={reaction} />,
[reaction, reactions], [reaction, reactions],
); );
const { onMouseEnter, onMouseLeave } = useTooltip({ const { onMouseEnter, onMouseLeave } = useTooltip({
createTooltip: createReactionTooltip, createTooltip: createReactionTooltip,
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines