Differential D11731

[lib/web/native] implement sending confirmation of processed message
ClosedPublic
Actions

Authored by kamil on Mon, Apr 22, 5:52 PM.

Tags

None

Referenced Files

	F1697538: D11731.id39655.diff
	Fri, May 3, 7:04 PM

	Unknown Object (File)
	Thu, May 2, 9:38 PM

	Unknown Object (File)
	Thu, May 2, 12:25 AM

	Unknown Object (File)
	Mon, Apr 29, 10:00 AM

	Unknown Object (File)
	Sat, Apr 27, 1:12 PM

	Unknown Object (File)
	Thu, Apr 25, 8:25 PM

	Unknown Object (File)
	Tue, Apr 23, 1:50 AM

	Unknown Object (File)
	Tue, Apr 23, 1:49 AM

View All 9 Files

Subscribers

Details

Reviewers

tomek
marcin

Commits

rCOMM76f9dbf4650f: [lib/web/native] implement sending confirmation of processed message

Summary

Confirmation after the message is processed.

Implementing only sending - the handling of confirmation will be implemented in the next goal Broadcasting information to peers.

This is the logic for a non-primary device where we could confirm the message right after processing DB ops. For primary we will have to wait until the backup log is uploaded, this is tracked in Backup client changes for syncing data & log upload. (cc. @marcin)

Depends on D11730, D11729

Test Plan

Manually add some messages and process them, check if confirmation is sent

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Apr 22, 5:52 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMon, Apr 22, 5:52 PM

kamil added a parent revision: D11739: [web] render `DBOpsHandler` in `TunnelbrokerProvider`.Tue, Apr 23, 5:18 AM

kamil edited the summary of this revision. (Show Details)Tue, Apr 23, 6:30 AM

kamil added a reviewer: marcin.

kamil added a subscriber: marcin.

kamil published this revision for review.Tue, Apr 23, 6:42 AM

marcin accepted this revision.Fri, Apr 26, 7:20 AM

This revision is now accepted and ready to land.Fri, Apr 26, 7:20 AM

rebase

Harbormaster completed remote builds in B28576: Diff 39655.Mon, Apr 29, 6:24 AM

Closed by commit rCOMM76f9dbf4650f: [lib/web/native] implement sending confirmation of processed message (authored by kamil). · Explain WhyMon, Apr 29, 6:29 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM76f9dbf4650f: [lib/web/native] implement sending confirmation of processed message.

Revision Contents
Changeset List

Path

Size

lib/

handlers/

db-ops-handler.react.js

24 lines

types/

tunnelbroker/

peer-to-peer-message-types.js

15 lines

Diff 39656

lib/handlers/db-ops-handler.react.js

Loading...

lib/types/tunnelbroker/peer-to-peer-message-types.js

Loading...