Page MenuHomePhabricator
Differential D11847

[native] Show "unknown error" alert if keyserver auth fails during registration
ClosedPublic
Actions

Authored by ashoat on Apr 30 2024, 11:38 AM.
Tags
None
Referenced Files
F5109520: D11847.id39722.diff
Tue, Apr 1, 7:25 PM
F5109298: D11847.diff
Tue, Apr 1, 6:12 PM
Unknown Object (File)
Mon, Mar 10, 5:27 AM
Unknown Object (File)
Thu, Mar 6, 5:09 AM
Unknown Object (File)
Feb 27 2025, 6:39 AM
Unknown Object (File)
Feb 27 2025, 6:24 AM
Unknown Object (File)
Feb 26 2025, 3:26 AM
Unknown Object (File)
Feb 26 2025, 3:26 AM
View All Files
Subscribers
inka
tomek

Details

Reviewers
varun
Commits
rCOMMd94e8201ccc7: [native] Show "unknown error" alert if keyserver auth fails during registration
Summary

We display this "unknown error" alert when identity auth fails, but for keyserver auth we're just failing silently. I think it's best to be consistent and show some alert indicating the error.

Depends on D11846

Test Plan

Confirm the Alert displays

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
account/
registration/
7 lines

Diff 39746

View Options

native/account/registration/registration-server-call.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines size_t decryptedSize = ::olm_decrypt(
decryptedMessage.data(), decryptedMessage.data(),
decryptedMessage.size()); decryptedMessage.size());
if (decryptedSize == -1) { if (decryptedSize == -1) {
throw std::runtime_error{ throw std::runtime_error{
"error decrypt => " + std::string{::olm_session_last_error(session)} + "error decrypt => " + std::string{::olm_session_last_error(session)} +
". Hash: " + ". Hash: " +
std::string{messageHashBuffer.begin(), messageHashBuffer.end()}}; std::string{messageHashBuffer.begin(), messageHashBuffer.end()}};
} }
return std::string{(char *)decryptedMessage.data(), decryptedSize}; return std::string{decryptedMessage.begin(), decryptedMessage.end()};
} }
std::string Session::decryptSequential(EncryptedData &encryptedData) { std::string Session::decryptSequential(EncryptedData &encryptedData) {
OlmSession *session = this->getOlmSession(); OlmSession *session = this->getOlmSession();
OlmBuffer utilityBuffer(::olm_utility_size()); OlmBuffer utilityBuffer(::olm_utility_size());
OlmUtility *olmUtility = ::olm_utility(utilityBuffer.data()); OlmUtility *olmUtility = ::olm_utility(utilityBuffer.data());
Show All 28 Lines size_t decryptedSize = ::olm_decrypt_sequential(
decryptedMessage.data(), decryptedMessage.data(),
decryptedMessage.size()); decryptedMessage.size());
if (decryptedSize == -1) { if (decryptedSize == -1) {
throw std::runtime_error{ throw std::runtime_error{
"error decrypt_sequential => " + "error decrypt_sequential => " +
std::string{::olm_session_last_error(session)} + ". Hash: " + std::string{::olm_session_last_error(session)} + ". Hash: " +
std::string{messageHashBuffer.begin(), messageHashBuffer.end()}}; std::string{messageHashBuffer.begin(), messageHashBuffer.end()}};
} }
return std::string{(char *)decryptedMessage.data(), decryptedSize}; return std::string{decryptedMessage.begin(), decryptedMessage.end()};
} }
int Session::getVersion() { int Session::getVersion() {
return this->version; return this->version;
} }
void Session::setVersion(int newVersion) { void Session::setVersion(int newVersion) {
this->version = newVersion; this->version = newVersion;
} }
} // namespace crypto } // namespace crypto
} // namespace comm } // namespace comm