[native] Show "unknown error" alert if keyserver auth fails during registration
ClosedPublic
Actions

Authored by ashoat on Apr 30 2024, 11:38 AM.

Details

Reviewers

varun

Commits

rCOMMd94e8201ccc7: [native] Show "unknown error" alert if keyserver auth fails during registration

Summary

We display this "unknown error" alert when identity auth fails, but for keyserver auth we're just failing silently. I think it's best to be consistent and show some alert indicating the error.

Depends on D11846

Test Plan

Confirm the Alert displays

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 30 2024, 11:38 AM

Harbormaster completed remote builds in B28608: Diff 39712.Apr 30 2024, 11:55 AM

ashoat requested review of this revision.Apr 30 2024, 11:55 AM

ashoat added a child revision: D11848: [lib][native] Automatically retry keyserverAuth during login/registration.Apr 30 2024, 12:28 PM

varun accepted this revision.May 1 2024, 10:21 AM

This revision is now accepted and ready to land.May 1 2024, 10:21 AM

Rework following updates in D11845 to avoid showing two alerts

Harbormaster completed remote builds in B28616: Diff 39722.May 1 2024, 3:18 PM

Closed by commit rCOMMd94e8201ccc7: [native] Show "unknown error" alert if keyserver auth fails during registration (authored by ashoat). · Explain WhyMay 2 2024, 8:15 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMd94e8201ccc7: [native] Show "unknown error" alert if keyserver auth fails during registration.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

registration-server-call.js

7 lines

Diff 39746

View Options

native/account/registration/registration-server-call.js

[native] Show "unknown error" alert if keyserver auth fails during registrationClosedPublicActions