Page MenuHomePhabricator
Differential D11847

[native] Show "unknown error" alert if keyserver auth fails during registration
ClosedPublic
Actions

Authored by ashoat on Apr 30 2024, 11:38 AM.
Tags
None
Referenced Files
F5120001: D11847.id39746.diff
Thu, Apr 3, 5:36 AM
Unknown Object (File)
Wed, Apr 2, 7:44 AM
Unknown Object (File)
Wed, Apr 2, 12:13 AM
Unknown Object (File)
Tue, Apr 1, 7:25 PM
Unknown Object (File)
Tue, Apr 1, 6:12 PM
Unknown Object (File)
Mon, Mar 10, 5:27 AM
Unknown Object (File)
Thu, Mar 6, 5:09 AM
Unknown Object (File)
Feb 27 2025, 6:39 AM
View All Files
Subscribers
inka
tomek

Details

Reviewers
varun
Commits
rCOMMd94e8201ccc7: [native] Show "unknown error" alert if keyserver auth fails during registration
Summary

We display this "unknown error" alert when identity auth fails, but for keyserver auth we're just failing silently. I think it's best to be consistent and show some alert indicating the error.

Depends on D11846

Test Plan

Confirm the Alert displays

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
account/
registration/
7 lines

Diff 39746

View Options

native/account/registration/registration-server-call.js

// @flow // @flow
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
getOlmSessionInitializationData, getOlmSessionInitializationData,
getOlmSessionInitializationDataActionTypes, getOlmSessionInitializationDataActionTypes,
} from '../actions/user-actions.js'; } from '../actions/user-actions.js';
import { cookieSelector } from '../selectors/keyserver-selectors.js'; import { cookieSelector } from '../selectors/keyserver-selectors.js';
import { OlmSessionCreatorContext } from '../shared/olm-session-creator-context.js';
import type { OLMOneTimeKeys, OLMPrekey } from '../types/crypto-types.js'; import type { OLMOneTimeKeys, OLMPrekey } from '../types/crypto-types.js';
import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js'; import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
CallSingleKeyserverEndpoint, CallSingleKeyserverEndpoint,
} from '../utils/call-single-keyserver-endpoint.js'; } from '../utils/call-single-keyserver-endpoint.js';
import { getConfig } from '../utils/config.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useDispatchActionPromise } from '../utils/redux-promise-utils.js'; import { useDispatchActionPromise } from '../utils/redux-promise-utils.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
export type InitialNotifMessageOptions = { export type InitialNotifMessageOptions = {
+callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint, +callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint,
+callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions, +callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions,
}; };
const initialEncryptedMessageContent = { const initialEncryptedMessageContent = {
type: 'init', type: 'init',
}; };
function useInitialNotificationsEncryptedMessage( function useInitialNotificationsEncryptedMessage(
keyserverID: string, keyserverID: string,
): (options?: ?InitialNotifMessageOptions) => Promise<string> { ): (options?: ?InitialNotifMessageOptions) => Promise<string> {
const callGetOlmSessionInitializationData = useLegacyAshoatKeyserverCall( const callGetOlmSessionInitializationData = useLegacyAshoatKeyserverCall(
getOlmSessionInitializationData, getOlmSessionInitializationData,
); );
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const cookie = useSelector(cookieSelector(keyserverID)); const cookie = useSelector(cookieSelector(keyserverID));
const olmSessionCreator = React.useContext(OlmSessionCreatorContext); const { olmAPI } = getConfig();
invariant(olmSessionCreator, 'Olm session creator should be set');
const { notificationsSessionCreator } = olmSessionCreator;
return React.useCallback( return React.useCallback(
async options => { async options => {
const callSingleKeyserverEndpoint = options?.callSingleKeyserverEndpoint; const callSingleKeyserverEndpoint = options?.callSingleKeyserverEndpoint;
const callSingleKeyserverEndpointOptions = const callSingleKeyserverEndpointOptions =
options?.callSingleKeyserverEndpointOptions; options?.callSingleKeyserverEndpointOptions;
const initDataAction = callSingleKeyserverEndpoint const initDataAction = callSingleKeyserverEndpoint
? getOlmSessionInitializationData(callSingleKeyserverEndpoint) ? getOlmSessionInitializationData(callSingleKeyserverEndpoint)
: callGetOlmSessionInitializationData; : callGetOlmSessionInitializationData;
const olmSessionDataPromise = initDataAction( const olmSessionDataPromise = initDataAction(
callSingleKeyserverEndpointOptions, callSingleKeyserverEndpointOptions,
); );
void dispatchActionPromise( void dispatchActionPromise(
getOlmSessionInitializationDataActionTypes, getOlmSessionInitializationDataActionTypes,
olmSessionDataPromise, olmSessionDataPromise,
); );
const { signedIdentityKeysBlob, notifInitializationInfo } = const [{ signedIdentityKeysBlob, notifInitializationInfo }] =
await olmSessionDataPromise; await Promise.all([
olmSessionDataPromise,
olmAPI.initializeCryptoAccount(),
]);
const { notificationIdentityPublicKeys } = JSON.parse( const { notificationIdentityPublicKeys } = JSON.parse(
signedIdentityKeysBlob.payload, signedIdentityKeysBlob.payload,
); );
return await notificationsSessionCreator( return await olmAPI.notificationsSessionCreator(
cookie, cookie,
notificationIdentityPublicKeys, notificationIdentityPublicKeys,
notifInitializationInfo, notifInitializationInfo,
keyserverID, keyserverID,
); );
}, },
[ [
callGetOlmSessionInitializationData, callGetOlmSessionInitializationData,
dispatchActionPromise, dispatchActionPromise,
notificationsSessionCreator, olmAPI,
cookie, cookie,
keyserverID, keyserverID,
], ],
); );
} }
function getOneTimeKeyValues( function getOneTimeKeyValues(
oneTimeKeys: OLMOneTimeKeys, oneTimeKeys: OLMOneTimeKeys,
Show All 26 Lines