Page MenuHomePhabricator
Differential D11883

[lib][native] Unshim FARCASTER_MUTUAL messages on the client
ClosedPublic
Actions

Authored by ashoat on Sun, May 5, 12:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 11, 10:16 PM
Unknown Object (File)
Fri, May 10, 3:18 PM
Unknown Object (File)
Thu, May 9, 1:21 PM
Unknown Object (File)
Sun, May 5, 3:07 PM
Unknown Object (File)
Sun, May 5, 3:01 PM
Unknown Object (File)
Sun, May 5, 2:51 PM
Subscribers
tomek

Details

Reviewers
ginsu
atul
Commits
rCOMMa4d35ff3939a: [lib][native] Unshim FARCASTER_MUTUAL messages on the client
Summary

This addresses ENG-7991 and ENG-7992.

Depends on D11871

Test Plan

Tested sending a shimmed message to a client (both native and web) and confirmed it was unshimmed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Sun, May 5, 12:20 PM
Herald added a subscriber: tomek. · View Herald TranscriptSun, May 5, 12:20 PM
ashoat added a reviewer: atul.Sun, May 5, 12:20 PM
ashoat added a child revision: D11884: [web] Factor out handleReduxMigrationFailure.Sun, May 5, 12:23 PM
ashoat added inline comments.Sun, May 5, 12:35 PM
lib/shared/messages/update-relationship-message-spec.js
277 ↗(On Diff #39792)

I don't think we need majorDesktop here at all... desktop version doesn't matter for gating these messages

ashoat edited the summary of this revision. (Show Details)Sun, May 5, 12:36 PM
Harbormaster completed remote builds in B28666: Diff 39792.Sun, May 5, 12:57 PM
ashoat requested review of this revision.Sun, May 5, 12:57 PM
ginsu accepted this revision.Sun, May 5, 4:36 PM
This revision is now accepted and ready to land.Sun, May 5, 4:36 PM
Closed by commit rCOMMa4d35ff3939a: [lib][native] Unshim FARCASTER_MUTUAL messages on the client (authored by ashoat). · Explain WhyTue, May 7, 7:48 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMa4d35ff3939a: [lib][native] Unshim FARCASTER_MUTUAL messages on the client.

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
9 lines
1 line
native/
redux/
4 lines

Diff 39904

View Options

lib/shared/messages/update-relationship-message-spec.js

Loading...
View Options

lib/shared/unshim-utils.js

Loading...
View Options

native/redux/persist.js

Loading...