Page MenuHomePhabricator
Differential D11885

[web] Introduce unshimClientDB and use it to unshim FARCASTER_MUTUAL messages
ClosedPublic
Actions

Authored by ashoat on May 5 2024, 12:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 12:12 PM
Unknown Object (File)
Tue, Apr 15, 2:45 PM
Unknown Object (File)
Tue, Apr 15, 10:37 AM
Unknown Object (File)
Tue, Apr 15, 9:01 AM
Unknown Object (File)
Tue, Apr 15, 4:05 AM
Unknown Object (File)
Mon, Apr 14, 9:14 AM
Unknown Object (File)
Fri, Apr 11, 11:39 AM
Unknown Object (File)
Mon, Apr 7, 9:52 AM
View All 90 Files
Subscribers
None

Details

Reviewers
tomek
kamil
ginsu
atul
Commits
rCOMM10f1996d18c4: [web] Introduce unshimClientDB and use it to unshim FARCASTER_MUTUAL messages
Summary

This is loosely based on unshimClientDB on native (link).

Some changes have been made, which will be brought over to the native version in a later diff in the stack.

This addresses ENG-7993.

Depends on D11884

Test Plan

Tested the migration on a web client

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.May 5 2024, 12:26 PM
ashoat added a child revision: D11886: [native] Factor out handleReduxMigrationFailure.
ashoat edited the summary of this revision. (Show Details)May 5 2024, 12:37 PM
ashoat added reviewers: ginsu, atul.
ashoat updated this revision to Diff 39800.May 5 2024, 12:39 PM

Replace FUTURE_CODE_VERSION with NEXT_CODE_VERSION for web

Harbormaster completed remote builds in B28668: Diff 39794.May 5 2024, 1:07 PM
Harbormaster completed remote builds in B28674: Diff 39800.May 5 2024, 1:34 PM
ashoat requested review of this revision.May 5 2024, 1:34 PM
tomek accepted this revision.May 6 2024, 1:04 AM
tomek added 1 blocking reviewer(s): kamil.
kamil accepted this revision.May 6 2024, 3:43 AM
This revision is now accepted and ready to land.May 6 2024, 3:43 AM
Closed by commit rCOMM10f1996d18c4: [web] Introduce unshimClientDB and use it to unshim FARCASTER_MUTUAL messages (authored by ashoat). · Explain WhyMay 7 2024, 7:48 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM10f1996d18c4: [web] Introduce unshimClientDB and use it to unshim FARCASTER_MUTUAL messages.
tomek mentioned this in D14561: [native][web] Add migrations unshimming delete messages.Thu, Apr 10, 5:50 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
8 lines
web/
redux/
3 lines
96 lines

Diff 39906

View Options

lib/shared/messages/update-relationship-message-spec.js

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines
View Options

web/redux/persist.js

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines
View Options

web/redux/unshim-utils.js

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines