[lib] Add function to verify device lists
ClosedPublic
Actions

Authored by bartek on Wed, May 8, 12:03 AM.

Details

Reviewers

kamil

Commits

rCOMMb694f848dd5f: [lib] Add function to verify device lists

Summary

Added function that verifies device lists timestamps and signatures on client side - Whitepaper 6.2.4
Now, we use Identity Service as a source of truth for device list updates.
Signatures are optional at this point, unsigned lists should still be accepted.

Depends on D11901, D11907

Test Plan

Added unit tests in D11930. More detailed plan will be performed when the function is used.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Wed, May 8, 12:03 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, May 8, 12:03 AM

bartek added a child revision: D11930: [lib] Add unit tests for device list verification.Wed, May 8, 12:04 AM

bartek edited the test plan for this revision. (Show Details)Wed, May 8, 12:04 AM

Harbormaster completed remote builds in B28747: Diff 39911.Wed, May 8, 12:34 AM

bartek published this revision for review.Wed, May 8, 11:51 PM

ashoat added inline comments.Thu, May 9, 6:23 AM

lib/shared/device-list-utils.js
10–23 ↗	(On Diff #39911)	Should we make all of these fields read-only by prefixing them with a `+`? (eg. `{ +valid: true }`)

Instead of calling JSON.parse to get RawDeviceList I would extract code parsing code with asserting from here to a separate function and use it here in all call sites.

This revision is now accepted and ready to land.Fri, May 10, 4:04 AM

Make types read-only. Extract function to parse raw device list.

Harbormaster completed remote builds in B28831: Diff 40066.Fri, May 10, 6:44 AM

Closed by commit rCOMMb694f848dd5f: [lib] Add function to verify device lists (authored by bartek). · Explain WhyFri, May 10, 7:24 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMb694f848dd5f: [lib] Add function to verify device lists.