Paths

Table of Contentst

Differential D11956

[lib] Verify device lists when received update from peer
ClosedPublic
Actions

Authored by bartek on May 9 2024, 2:54 AM.

Tags

None

Referenced Files

	F3524213: D11956.diff
	Mon, Dec 23, 11:38 AM

	Unknown Object (File)
	Sat, Dec 21, 6:30 PM

	Unknown Object (File)
	Sat, Dec 21, 6:30 PM

	Unknown Object (File)
	Sat, Dec 21, 6:30 PM

	Unknown Object (File)
	Sat, Dec 21, 6:30 PM

	Unknown Object (File)
	Nov 17 2024, 3:26 AM

	Unknown Object (File)
	Nov 17 2024, 2:57 AM

	Unknown Object (File)
	Nov 17 2024, 12:45 AM

View All 51 Files

Subscribers

ashoat

tomek

Details

Reviewers

kamil

Commits

rCOMMbba1ff7e2c40: [lib] Verify device lists when received update from peer

Summary

Added a case to peerToPeerMessageHandler for device list updates.
Added some console logs to print verification status.

Depends on D11930

Test Plan

Ran QR auth and observed the result on another device.
Modified the primary device to send invalid updates and observed failure logs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 9 2024, 2:54 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 9 2024, 2:54 AM

bartek published this revision for review.May 9 2024, 3:09 AM

Harbormaster completed remote builds in B28782: Diff 39978.May 9 2024, 3:10 AM

kamil accepted this revision.May 10 2024, 5:05 AM

This revision is now accepted and ready to land.May 10 2024, 5:05 AM

Closed by commit rCOMMbba1ff7e2c40: [lib] Verify device lists when received update from peer (authored by bartek). · Explain WhyMay 10 2024, 7:24 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMbba1ff7e2c40: [lib] Verify device lists when received update from peer.

Revision Contents
Changeset List

Path

Size

lib/

handlers/

peer-to-peer-message-handler.js

35 lines

Diff 40071

View Options

lib/handlers/peer-to-peer-message-handler.js

[lib] Verify device lists when received update from peerClosedPublicActions