[lib] Use tUserID in entry-validators.js pt.1
ClosedPublic
Actions

Authored by inka on May 9 2024, 4:03 AM.

Details

Reviewers

tomek
kamil
bartek

Commits

rCOMM4efcfd6c8c96: [lib] Use tUserID in entry-validators.js pt.1

Summary

issue: ENG-7819

The approach I took is to go through all validators files in lib/types/validators and for each file, for each validator, recursively update all validators it uses

Test Plan

flow
Tested that fetch_entries endpoint which uses fetchEntryInfosResponseValidator works correctly and doesn't throw errors

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.May 9 2024, 4:03 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 9 2024, 4:03 AM

inka added a child revision: D11962: [lib] Use tUserID in entry-validators.js pt.2 - rawMessageInfoValidator.May 9 2024, 4:06 AM

inka added a parent revision: D11960: [lib] Add tUserID.

Harbormaster completed remote builds in B28788: Diff 39984.May 9 2024, 4:19 AM

inka requested review of this revision.May 9 2024, 4:19 AM

inka edited the summary of this revision. (Show Details)May 9 2024, 6:00 AM

It might be a good idea to have a sanity check in a test plan to verify if the responses are validated correctly (if sending and receiving responses from keyserver work, for a couple of endpoints).

This revision is now accepted and ready to land.May 9 2024, 7:59 AM

In D11961#342248, @tomek wrote:

It might be a good idea to have a sanity check in a test plan to verify if the responses are validated correctly (if sending and receiving responses from keyserver work, for a couple of endpoints).

Amended the test plan, going to check some other responders and amend test plans in proper diffs

Closed by commit rCOMM4efcfd6c8c96: [lib] Use tUserID in entry-validators.js pt.1 (authored by inka). · Explain WhyMay 10 2024, 2:39 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM4efcfd6c8c96: [lib] Use tUserID in entry-validators.js pt.1.