[native] Remove CoolOrNerdModeSelection and KeyserverSelection from registration flow
ClosedPublic
Actions

Authored by ashoat on May 9 2024, 7:40 AM.

Details

Reviewers

ginsu
inka

Commits

rCOMM1f290eb14d38: [native] Remove CoolOrNerdModeSelection and KeyserverSelection from…

Summary

This diff keeps them in the codebase for now, in case we want to bring this back.

Test Plan

Tested opening the registration flow from the main screen and from FullscreenSIWEPanel. Make sure CoolOrNerdModeSelection and KeyserverSelection don't appear. Make sure that I am able to successfully register

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 9 2024, 7:40 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 9 2024, 7:40 AM

ashoat added a child revision: D11973: [native] Swap order of ConnectEthereum and ConnectFarcaster in registration flow.May 9 2024, 7:41 AM

Harbormaster completed remote builds in B28810: Diff 40019.May 9 2024, 7:57 AM

ashoat requested review of this revision.May 9 2024, 7:57 AM

inka accepted this revision.May 9 2024, 8:23 AM

inka added inline comments.

native/account/registration/connect-ethereum.react.js
66 ↗	(On Diff #40019)	So currently, all users will see the "nerd" version, right? I think that's good, just wanted to flag this

This revision is now accepted and ready to land.May 9 2024, 8:23 AM

Remove config that is now unnecessary in FullscreenSIWEPanel

ashoat added inline comments.May 9 2024, 11:29 AM

native/account/registration/connect-ethereum.react.js
66 ↗	(On Diff #40019)	No, it's actually the opposite. `userSelections?.coolOrNerdMode` will be `undefined`, so `isNerdMode` will be `false`, and this check will evaluate as `true`