Page MenuHomePhabricator

[native] Disable React Native LayoutAnimation on Android
ClosedPublic

Authored by ashoat on May 10 2024, 9:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 5:10 AM
Unknown Object (File)
Fri, Nov 1, 11:48 PM
Unknown Object (File)
Oct 12 2024, 11:43 AM
Unknown Object (File)
Oct 12 2024, 11:43 AM
Unknown Object (File)
Oct 12 2024, 11:43 AM
Unknown Object (File)
Oct 12 2024, 11:43 AM
Unknown Object (File)
Sep 13 2024, 5:15 PM
Unknown Object (File)
Aug 29 2024, 5:53 PM
Subscribers

Details

Summary

This has been experimental forever and never fully shipped. I suspect that it's causing ENG-7774, but unfortunately I have no way to prove it because I don't have a repro.

We use LayoutAnimation in three places:

  1. The calendar tab
  2. Animating messages when they're focused
  3. Animating the content window along with the keyboard when the keyboard appears or disappears (in KeyboardAvoidingView). In my experience, this has never worked on Android. I think that's because easing is never set in keyboard events
Test Plan

To be honest, I don't have a good test plan here because I've never been able to reproduce the original issue. While I don't have a good way to test, I think it's better to proceed with this, as the issue in question is pretty bad, and there isn't much cost here, since there aren't that many animations that rely on LayoutAnimation.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable