issue: ENG-8080
As I explained in the issue, I wanted to simply use those objects instead of objects in lib/types/endpoints.js. But this causes very complicated import cycles. I know how to solve them, but it would requre refactoring a lot of files, hundreds possibly.
So instead I am creating a separate file with this mapping endpoint-output validator. The dev will not be able to forget about adding the validator here, because that would cause flow issues in the next diff.
Details
Details
Tested with next diffs - checked a couple of endpoints, and verified that no errors are thrown if outputs are validated with validators specified by endpointValidators for those endpoints.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/types/validators/endpoint-validators.js | ||
|---|---|---|
| 65–110 ↗ | (On Diff #40158) | Why do we split these into multiple objects but export a single value? |
| lib/types/validators/endpoint-validators.js | ||
|---|---|---|
| 65–110 ↗ | (On Diff #40158) | I kept them split the way they are split in lib/types/endpoints.js. No reason I suppose, I just found it to be easier to navigate |