Page MenuHomePhabricator

[lib] update types to allow missing OTK when creating session
ClosedPublic

Authored by kamil on Thu, May 23, 4:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 11, 1:44 PM
Unknown Object (File)
Tue, Jun 11, 6:14 AM
Unknown Object (File)
Mon, Jun 10, 3:45 PM
Unknown Object (File)
Mon, Jun 10, 1:28 PM
Unknown Object (File)
Mon, Jun 10, 8:58 AM
Unknown Object (File)
Mon, Jun 10, 2:18 AM
Unknown Object (File)
Sun, Jun 9, 12:39 PM
Unknown Object (File)
Sun, Jun 9, 9:12 AM
Subscribers

Details

Summary

Modifying types and callsites to reflect new olm API.

Depends on D12203

Test Plan

Tested end-to-end:

  1. Tested content session with OTKs on both web and native
  2. Tested content session without OTKs on both web native
  3. Tested notifs
  4. Tested backward compatibility: @marcin was running his devices logged to staging on old olm version, and I was running the new version (this stack). WIth one OTKs it works as previously (tested both me and Marcin sending requests to each other and tested both platform). When there are no OTKs Marcin was unable to create a session request (same as now), I was able to create a session request, but it failed on Martin’s device with BAD_MESSAGE_KEY_ID but without crashing the app.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Thu, May 23, 5:50 AM

Note to myself to update the code after D12131 is landed

This revision is now accepted and ready to land.Tue, May 28, 4:39 AM
  • update createOlmSessionWithPeer
  • rebase before landing