Page MenuHomePhabricator
Differential D12131

[lib] creating `olm` session with device
ClosedPublic
Actions

Authored by kamil on May 20 2024, 4:31 PM.
Tags
None
Referenced Files
F2058379: D12131.id40422.diff
Thu, Jun 20, 5:29 PM
F2058292: D12131.diff
Thu, Jun 20, 5:26 PM
F2057922: D12131.id.diff
Thu, Jun 20, 4:56 PM
Unknown Object (File)
Wed, Jun 19, 9:49 AM
Unknown Object (File)
Tue, Jun 18, 9:03 PM
Unknown Object (File)
Wed, Jun 12, 7:48 AM
Unknown Object (File)
Mon, Jun 10, 10:35 AM
Unknown Object (File)
Sun, Jun 9, 11:24 PM
View All 22 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMM72f120f04045: [lib] creating `olm` session with device
Summary

Method to create a session with one peer.

It looks similar but differs from createOlmSessionsWithOwnDevices and trying to duplicate could make the code more complex - additionally createOlmSessionsWithOwnDevices is only for testing and will be removed

Depends on D12130

Test Plan

Call method and test if session creation works, in case of failure error is thrown

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.May 20 2024, 4:31 PM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMay 20 2024, 4:31 PM
kamil edited the summary of this revision. (Show Details)May 20 2024, 4:33 PM
kamil retitled this revision from [web][native] creating `olm` session with device to [lib] creating `olm` session with device.
kamil added a child revision: D12132: [lib] introduce context to process Outbound P2P Messages.May 20 2024, 4:41 PM
Harbormaster completed remote builds in B29073: Diff 40422.May 20 2024, 4:50 PM
kamil published this revision for review.May 21 2024, 1:27 AM
kamil edited the summary of this revision. (Show Details)
kamil added inline comments.
lib/utils/crypto-utils.js
168–170 ↗(On Diff #40422)

at the current state it's helpful to debug but we should remove it soon as this could cause spam in the future

bartek accepted this revision.Thu, May 23, 6:40 AM
This revision is now accepted and ready to land.Thu, May 23, 6:40 AM
kamil updated this revision to Diff 40637.Fri, May 24, 8:17 AM

rebase before landing

kamil mentioned this in D12204: [lib] update types to allow missing OTK when creating session.Fri, May 24, 8:28 AM
Harbormaster completed remote builds in B29240: Diff 40637.Fri, May 24, 8:36 AM
Closed by commit rCOMM72f120f04045: [lib] creating `olm` session with device (authored by kamil). · Explain WhyFri, May 24, 8:39 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM72f120f04045: [lib] creating `olm` session with device.

Revision Contents
Changeset List

PathSize
lib/
utils/
61 lines

Diff 40640

View Options

lib/utils/crypto-utils.js

Loading...