Page MenuHomePhabricator
Differential D12047

[lib] rename `MessageToDevice` from SQLite to `OutboundP2PMessage`
ClosedPublic
Actions

Authored by kamil on May 15 2024, 3:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 21, 7:39 AM
Unknown Object (File)
Fri, Feb 21, 7:39 AM
Unknown Object (File)
Fri, Feb 21, 7:38 AM
Unknown Object (File)
Feb 3 2025, 8:25 AM
Unknown Object (File)
Feb 1 2025, 11:29 PM
Unknown Object (File)
Jan 27 2025, 7:39 PM
Unknown Object (File)
Jan 22 2025, 1:27 AM
Unknown Object (File)
Jan 18 2025, 9:53 AM
View All 53 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMMfd41bc15f934: [lib] rename `MessageToDevice` from SQLite to `OutboundP2PMessage`
Summary

MessageToDevice and ClientMessageToDevice are used in different context in codebase which makes it hard to understand and confusing, renaming to OutboundP2PMessage.

Depends on D12046

Test Plan

Flow & tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.May 15 2024, 3:56 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMay 15 2024, 3:56 AM
Harbormaster completed remote builds in B28933: Diff 40207.May 15 2024, 4:12 AM
kamil published this revision for review.May 16 2024, 1:34 AM
kamil added a child revision: D12068: [SQLite] recreate table for Outbound P2P messages.May 16 2024, 4:44 AM
kamil added inline comments.May 16 2024, 5:03 AM
native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
145 ↗(On Diff #40207)

missed that one - going to add in next rebase

bartek accepted this revision.May 16 2024, 7:13 AM
This revision is now accepted and ready to land.May 16 2024, 7:13 AM
kamil updated this revision to Diff 40295.May 16 2024, 10:01 AM

add missing rename

Harbormaster completed remote builds in B28991: Diff 40295.May 16 2024, 10:18 AM
Closed by commit rCOMMfd41bc15f934: [lib] rename `MessageToDevice` from SQLite to `OutboundP2PMessage` (authored by kamil). · Explain WhyMay 16 2024, 10:23 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMfd41bc15f934: [lib] rename `MessageToDevice` from SQLite to `OutboundP2PMessage`.

Revision Contents
Changeset List

PathSize
lib/
types/
9 lines
native/
cpp/
CommonCpp/
DatabaseManagers/
16 lines
14 lines
37 lines
entities/
OutboundP2PMessage.h
MessageToDevice.h
16 lines
web/
cpp/
31 lines
shared-worker/
_generated/
queries/
outbound-p2p-message-queries.test.js
message-to-device-queries.test.js
41 lines
types/
30 lines

Diff 40303

View Options

lib/types/sqlite-types.js

use tracing::error;
pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>; pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;
#[derive( #[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error, Debug, derive_more::Display, derive_more::From, derive_more::Error,
)] )]
pub enum WebsocketError { pub enum WebsocketError {
InvalidMessage, InvalidMessage,
InvalidSearchQuery,
UnauthorizedDevice, UnauthorizedDevice,
SendError, SendError,
SearchError, SearchError,
AuthError, AuthError,
SerializationError, SerializationError,
} }
impl From<serde_json::Error> for WebsocketError {
fn from(err: serde_json::Error) -> Self {
tracing::error!("Error serializing: {}", err);
WebsocketError::SerializationError
}
}
impl From<reqwest::Error> for WebsocketError {
fn from(err: reqwest::Error) -> Self {
tracing::error!("Error with search request: {}", err);
WebsocketError::SearchError
}
}
View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

use tracing::error;
pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>; pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;
#[derive( #[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error, Debug, derive_more::Display, derive_more::From, derive_more::Error,
)] )]
pub enum WebsocketError { pub enum WebsocketError {
InvalidMessage, InvalidMessage,
InvalidSearchQuery,
UnauthorizedDevice, UnauthorizedDevice,
SendError, SendError,
SearchError, SearchError,
AuthError, AuthError,
SerializationError, SerializationError,
} }
impl From<serde_json::Error> for WebsocketError {
fn from(err: serde_json::Error) -> Self {
tracing::error!("Error serializing: {}", err);
WebsocketError::SerializationError
}
}
impl From<reqwest::Error> for WebsocketError {
fn from(err: reqwest::Error) -> Self {
tracing::error!("Error with search request: {}", err);
WebsocketError::SearchError
}
}
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

use tracing::error;
pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>; pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;
#[derive( #[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error, Debug, derive_more::Display, derive_more::From, derive_more::Error,
)] )]
pub enum WebsocketError { pub enum WebsocketError {
InvalidMessage, InvalidMessage,
InvalidSearchQuery,
UnauthorizedDevice, UnauthorizedDevice,
SendError, SendError,
SearchError, SearchError,
AuthError, AuthError,
SerializationError, SerializationError,
} }
impl From<serde_json::Error> for WebsocketError {
fn from(err: serde_json::Error) -> Self {
tracing::error!("Error serializing: {}", err);
WebsocketError::SerializationError
}
}
impl From<reqwest::Error> for WebsocketError {
fn from(err: reqwest::Error) -> Self {
tracing::error!("Error with search request: {}", err);
WebsocketError::SearchError
}
}
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

use tracing::error;
pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>; pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;
#[derive( #[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error, Debug, derive_more::Display, derive_more::From, derive_more::Error,
)] )]
pub enum WebsocketError { pub enum WebsocketError {
InvalidMessage, InvalidMessage,
InvalidSearchQuery,
UnauthorizedDevice, UnauthorizedDevice,
SendError, SendError,
SearchError, SearchError,
AuthError, AuthError,
SerializationError, SerializationError,
} }
impl From<serde_json::Error> for WebsocketError {
fn from(err: serde_json::Error) -> Self {
tracing::error!("Error serializing: {}", err);
WebsocketError::SerializationError
}
}
impl From<reqwest::Error> for WebsocketError {
fn from(err: reqwest::Error) -> Self {
tracing::error!("Error with search request: {}", err);
WebsocketError::SearchError
}
}
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/MessageToDevice.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/OutboundP2PMessage.h

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/message-to-device-queries.test.js

Loading...
View Options

web/shared-worker/queries/outbound-p2p-message-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...