Page MenuHomePhabricator
Differential D12069

[SQLite] add table with inbound P2P messages to backup blocklist
ClosedPublic
Actions

Authored by kamil on May 16 2024, 4:52 AM.
Tags
None
Referenced Files
F3525483: D12069.id40591.diff
Mon, Dec 23, 5:14 PM
F3525482: D12069.id40282.diff
Mon, Dec 23, 5:14 PM
F3525470: D12069.id.diff
Mon, Dec 23, 5:14 PM
F3525463: D12069.diff
Mon, Dec 23, 5:14 PM
Unknown Object (File)
Mon, Dec 2, 4:35 AM
Unknown Object (File)
Nov 22 2024, 9:14 AM
Unknown Object (File)
Nov 22 2024, 8:59 AM
Unknown Object (File)
Nov 22 2024, 3:39 AM
View All 58 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMM490040c14024: [SQLite] add table with inbound P2P messages to backup blocklist
Summary

We shouldn't back up this table. In case of restore (when some messages are not yet processed) we should as other peers to resend messages encrypted with a new session.

This should be initially done in D11722.

Depends on D12068

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.May 16 2024, 4:52 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMay 16 2024, 4:52 AM
kamil retitled this revision from [SQLite] recreate table for Outbound P2P messages to [SQLite] add table with inbound P2P messages to backup blocklist.May 16 2024, 4:53 AM
Harbormaster completed remote builds in B28978: Diff 40282.May 16 2024, 5:07 AM
kamil published this revision for review.May 16 2024, 5:14 AM
kamil added a child revision: D12070: [SQLite] add query to set ciphertext for outbound P2P message.May 16 2024, 5:19 AM
marcin added inline comments.May 17 2024, 3:33 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
46 ↗(On Diff #40282)

In diff summary you say that we should "back up this table" but by adding it here you are preventing it from being backed up.

kamil edited the summary of this revision. (Show Details)May 17 2024, 3:36 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
46 ↗(On Diff #40282)

My bad - we shouldn't. Summary updated

marcin accepted this revision.May 17 2024, 6:16 AM
This revision is now accepted and ready to land.May 17 2024, 6:16 AM
Closed by commit rCOMM490040c14024: [SQLite] add table with inbound P2P messages to backup blocklist (authored by kamil). · Explain WhyMay 23 2024, 9:02 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM490040c14024: [SQLite] add table with inbound P2P messages to backup blocklist.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
1 line

Diff 40591

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...