[web] improve handling of non-existing olm sessions
ClosedPublic
Actions

Authored by kamil on May 15 2024, 1:38 AM.

Details

Reviewers

tomek
marcin

Commits

rCOMM029f7ae731a2: [web] improve handling of non-existing olm sessions

Summary

Previous code versions instead of No session for device... was causing runtime error: Cannot destructure property 'session' of cryptoStore.contentSessions [deviceID]..

Test Plan

Check encrypt/decrypt when session exists
Check encrypt/decrypt when session not exists

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 15 2024, 1:38 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 15 2024, 1:39 AM

kamil added a child revision: D12045: [lib] rename `ClientMessageToDevice` in `tunnelbroker-context.js` to `TunnelbrokerClientMessageToDevice`.May 15 2024, 1:46 AM

Harbormaster completed remote builds in B28930: Diff 40204.May 15 2024, 1:55 AM

kamil published this revision for review.May 16 2024, 1:34 AM

marcin accepted this revision.May 16 2024, 8:52 AM

This revision is now accepted and ready to land.May 16 2024, 8:52 AM

Closed by commit rCOMM029f7ae731a2: [web] improve handling of non-existing olm sessions (authored by kamil). · Explain WhyMay 16 2024, 10:22 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM029f7ae731a2: [web] improve handling of non-existing olm sessions.

Revision Contents
Changeset List

Path

Size

web/

shared-worker/

worker/

worker-crypto.js

18 lines

Diff 40300

View Options

web/shared-worker/worker/worker-crypto.js

				use tracing::error;

	pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;			pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;

	#[derive(			#[derive(
	Debug, derive_more::Display, derive_more::From, derive_more::Error,			Debug, derive_more::Display, derive_more::From, derive_more::Error,
	)]			)]
	pub enum WebsocketError {			pub enum WebsocketError {
	InvalidMessage,			InvalidMessage,
				InvalidSearchQuery,
	UnauthorizedDevice,			UnauthorizedDevice,
	SendError,			SendError,
	SearchError,			SearchError,
	AuthError,			AuthError,
	SerializationError,			SerializationError,
	}			}

				impl From<serde_json::Error> for WebsocketError {
				fn from(err: serde_json::Error) -> Self {
				tracing::error!("Error serializing: {}", err);
				WebsocketError::SerializationError
				}
				}

				impl From<reqwest::Error> for WebsocketError {
				fn from(err: reqwest::Error) -> Self {
				tracing::error!("Error with search request: {}", err);
				WebsocketError::SearchError
				}
				}

[web] improve handling of non-existing olm sessionsClosedPublicActions