Paths

Table of Contentst

Differential D12074

[SQLite] remove Outbound P2P messages based on `messageID` and `deviceID`
ClosedPublic
Actions

Authored by kamil on May 16 2024, 7:14 AM.

Tags

None

Referenced Files

	F3525491: D12074.id40595.diff
	Mon, Dec 23, 5:15 PM

	F3525476: D12074.id.diff
	Mon, Dec 23, 5:14 PM

	F3525457: D12074.diff
	Mon, Dec 23, 5:14 PM

	Unknown Object (File)
	Mon, Nov 25, 8:21 PM

	Unknown Object (File)
	Nov 22 2024, 8:46 AM

	Unknown Object (File)
	Nov 7 2024, 5:00 PM

	Unknown Object (File)
	Oct 14 2024, 4:58 PM

	Unknown Object (File)
	Oct 14 2024, 4:58 PM

View All 40 Files

Subscribers

Details

Reviewers

tomek
marcin

Commits

rCOMMdcb171a7b9fa: [SQLite] remove Outbound P2P messages based on `messageID` and `deviceID`

Summary

After processing the other peer will send only messageID - not full OutboundP2PMessage.

Depends on D12071

Test Plan

Tests

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 16 2024, 7:14 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 16 2024, 7:14 AM

Harbormaster completed remote builds in B28985: Diff 40289.May 16 2024, 7:29 AM

kamil added a child revision: D12075: [SQLite] remove `deviceID` param when getting all Outbound P2P messages.May 16 2024, 7:33 AM

kamil added inline comments.May 16 2024, 10:11 AM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1149 ↗	(On Diff #40289)	debugging leftover

kamil published this revision for review.May 17 2024, 3:23 AM

kamil added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2149–2152 ↗	(On Diff #40289)	not sure about indentation here

marcin added inline comments.May 17 2024, 6:28 AM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2149–2152 ↗	(On Diff #40289)	The convention is to sue the same SQL formatting conventions as we have on the keyserver. Take a look here: https://github.com/CommE2E/comm/blob/master/keyserver/src/creators/invite-link-creator.js#L158-L164
2159–2161 ↗	(On Diff #40289)	Please use `SQLiteDataConverters.h`
2164–2169 ↗	(On Diff #40289)	You can remove those lines - `SQLiteStatementWrapper` destructor does it automatically.

address review

Harbormaster completed remote builds in B29215: Diff 40588.May 23 2024, 8:42 AM

marcin accepted this revision.May 23 2024, 8:42 AM

This revision is now accepted and ready to land.May 23 2024, 8:42 AM

Closed by commit rCOMMdcb171a7b9fa: [SQLite] remove Outbound P2P messages based on `messageID` and `deviceID` (authored by kamil). · Explain WhyMay 23 2024, 9:02 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMdcb171a7b9fa: [SQLite] remove Outbound P2P messages based on `messageID` and `deviceID`.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

3 lines

SQLiteQueryExecutor.h

3 lines

SQLiteQueryExecutor.cpp

31 lines

web/

shared-worker/

_generated/

comm_query_executor.wasm

queries/

outbound-p2p-message-queries.test.js

11 lines

types/

sqlite-query-executor.js

3 lines

Diff 40595

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

web/shared-worker/_generated/comm_query_executor.wasm

Loading...

web/shared-worker/queries/outbound-p2p-message-queries.test.js

Loading...

web/shared-worker/types/sqlite-query-executor.js

Loading...