[lib] add sending Tunnelbroker message with already defined `messageID`
ClosedPublic
Actions

Authored by kamil on Thu, May 16, 8:53 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMM1ee2cddd84c4: [lib] add sending Tunnelbroker message with already defined `messageID`

Summary

Messages to other devices are generated when processing store ops, that's when messageID is generated, and we want to send it without generating new one.

Test Plan

Test sending Tunnelbroker messsages

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Thu, May 16, 8:53 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptThu, May 16, 8:53 AM

Harbormaster completed remote builds in B28989: Diff 40293.Thu, May 16, 9:09 AM

kamil added a child revision: D12077: [lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed`.Thu, May 16, 9:12 AM

kamil published this revision for review.Thu, May 16, 9:39 AM

bartek accepted this revision.Fri, May 17, 2:03 AM

This revision is now accepted and ready to land.Fri, May 17, 2:03 AM

bartek added inline comments.Fri, May 17, 2:05 AM

lib/tunnelbroker/tunnelbroker-context.js
388–392 ↗	(On Diff #40293)	I was thinking about an alternative approach - this might save some from introducing `sendMessageWithID` but it might have more drawbacks that I'm not aware of.