Page MenuHomePhabricator
Differential D12076

[lib] add sending Tunnelbroker message with already defined `messageID`
ClosedPublic
Actions

Authored by kamil on May 16 2024, 8:53 AM.
Tags
None
Referenced Files
F3525107: D12076.id40583.diff
Mon, Dec 23, 3:43 PM
F3525106: D12076.id40581.diff
Mon, Dec 23, 3:43 PM
F3525105: D12076.id40293.diff
Mon, Dec 23, 3:43 PM
F3525091: D12076.id.diff
Mon, Dec 23, 3:43 PM
F3525082: D12076.diff
Mon, Dec 23, 3:43 PM
Unknown Object (File)
Tue, Nov 26, 2:00 AM
Unknown Object (File)
Nov 22 2024, 9:26 AM
Unknown Object (File)
Oct 17 2024, 5:13 PM
View All 71 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMM1ee2cddd84c4: [lib] add sending Tunnelbroker message with already defined `messageID`
Summary

Messages to other devices are generated when processing store ops, that's when messageID is generated, and we want to send it without generating new one.

Test Plan

Test sending Tunnelbroker messsages

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.May 16 2024, 8:53 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMay 16 2024, 8:53 AM
Harbormaster completed remote builds in B28989: Diff 40293.May 16 2024, 9:09 AM
kamil added a child revision: D12077: [lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed`.May 16 2024, 9:12 AM
kamil published this revision for review.May 16 2024, 9:39 AM
bartek accepted this revision.May 17 2024, 2:03 AM
This revision is now accepted and ready to land.May 17 2024, 2:03 AM
bartek added inline comments.May 17 2024, 2:05 AM
lib/tunnelbroker/tunnelbroker-context.js
388–392 ↗(On Diff #40293)

I was thinking about an alternative approach - this might save some from introducing sendMessageWithID but it might have more drawbacks that I'm not aware of.

kamil updated this revision to Diff 40581.May 23 2024, 7:28 AM

address review

lib/tunnelbroker/tunnelbroker-context.js
388–392 ↗(On Diff #40293)

I think that's a good idea

Harbormaster completed remote builds in B29210: Diff 40581.May 23 2024, 7:45 AM
Closed by commit rCOMM1ee2cddd84c4: [lib] add sending Tunnelbroker message with already defined `messageID` (authored by kamil). · Explain WhyMay 23 2024, 7:53 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM1ee2cddd84c4: [lib] add sending Tunnelbroker message with already defined `messageID`.

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
10 lines

Diff 40583

View Options

lib/tunnelbroker/tunnelbroker-context.js

Loading...