Page MenuHomePhabricator

[lib] add sending Tunnelbroker message with already defined `messageID`
ClosedPublic

Authored by kamil on May 16 2024, 8:53 AM.
Tags
None
Referenced Files
F2064310: D12076.id40293.diff
Fri, Jun 21, 6:28 AM
Unknown Object (File)
Wed, Jun 19, 7:21 PM
Unknown Object (File)
Wed, Jun 19, 9:49 AM
Unknown Object (File)
Wed, Jun 19, 9:45 AM
Unknown Object (File)
Wed, Jun 19, 9:12 AM
Unknown Object (File)
Mon, Jun 10, 10:36 AM
Unknown Object (File)
Sun, Jun 9, 10:46 PM
Unknown Object (File)
Sun, Jun 9, 4:23 PM
Subscribers

Details

Summary

Messages to other devices are generated when processing store ops, that's when messageID is generated, and we want to send it without generating new one.

Test Plan

Test sending Tunnelbroker messsages

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.May 16 2024, 9:39 AM
This revision is now accepted and ready to land.May 17 2024, 2:03 AM
lib/tunnelbroker/tunnelbroker-context.js
388–392 ↗(On Diff #40293)

I was thinking about an alternative approach - this might save some from introducing sendMessageWithID but it might have more drawbacks that I'm not aware of.

address review

lib/tunnelbroker/tunnelbroker-context.js
388–392 ↗(On Diff #40293)

I think that's a good idea