Differential D12228

[keyserver] Don't create a thread with an admin when creating a new account
ClosedPublic
Actions

Authored by tomek on May 28 2024, 5:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 1, 8:12 PM

	Unknown Object (File)
	Sat, Jun 29, 2:29 AM

	Unknown Object (File)
	Thu, Jun 27, 11:35 AM

	Unknown Object (File)
	Thu, Jun 27, 11:35 AM

	Unknown Object (File)
	Thu, Jun 27, 11:35 AM

	Unknown Object (File)
	Fri, Jun 21, 9:59 PM

	Unknown Object (File)
	Tue, Jun 18, 2:33 AM

	Unknown Object (File)
	Sun, Jun 16, 5:42 PM

View All 35 Files

Subscribers

Details

Reviewers

inka
ginsu

Commits

rCOMMd47601c4ec75: [keyserver] Don't create a thread with an admin when creating a new account

Summary

On a non-auth keyserver we don't have access to GENESIS and can't create a thread within it.

https://linear.app/comm/issue/ENG-7844/dont-create-a-thread-with-an-admin-when-creating-a-new-account

Depends on D12227

Test Plan

Check if the private thread is created when setting up an authoritative keyserver. Check if the thread isn't created on a non-auth keyserver.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.May 28 2024, 5:43 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 28 2024, 5:43 AM

tomek added a child revision: D12229: [keyserver] Throw an exception when trying to create a DM on a non-auth keyserver.May 28 2024, 5:53 AM

Harbormaster completed remote builds in B29266: Diff 40688.May 28 2024, 6:00 AM

tomek requested review of this revision.May 28 2024, 6:00 AM

ashoat added inline comments.May 28 2024, 12:19 PM

keyserver/src/creators/account-creator.js
196 ↗	(On Diff #40688)	Why do we always create a private thread? Does the user need one private thread per keyserver? Eventually this will be client-local, but for now I think we should only generate it on the authoritative keyserver.

tomek added inline comments.May 29 2024, 1:45 AM

keyserver/src/creators/account-creator.js
196 ↗	(On Diff #40688)	Ok, that makes sense - will make it conditional.

Don't create a private thread

tomek edited the test plan for this revision. (Show Details)May 29 2024, 6:31 AM

Harbormaster completed remote builds in B29279: Diff 40740.May 29 2024, 6:50 AM

inka accepted this revision.May 29 2024, 7:19 AM

This revision is now accepted and ready to land.May 29 2024, 7:19 AM

Closed by commit rCOMMd47601c4ec75: [keyserver] Don't create a thread with an admin when creating a new account (authored by tomek). · Explain WhyMay 29 2024, 7:37 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMd47601c4ec75: [keyserver] Don't create a thread with an admin when creating a new account.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

account-creator.js

10 lines

Diff 40747

keyserver/src/creators/account-creator.js

Loading...