Differential D12229

[keyserver] Throw an exception when trying to create a DM on a non-auth keyserver
ClosedPublic
Actions

Authored by tomek on May 28 2024, 5:53 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jun 27, 11:35 AM

	Unknown Object (File)
	Thu, Jun 27, 11:35 AM

	Unknown Object (File)
	Thu, Jun 27, 11:35 AM

	Unknown Object (File)
	Tue, Jun 18, 8:11 AM

	Unknown Object (File)
	Wed, Jun 12, 5:39 AM

	Unknown Object (File)
	Mon, Jun 10, 4:35 PM

	Unknown Object (File)
	Mon, Jun 10, 4:45 AM

	Unknown Object (File)
	Sun, Jun 9, 10:38 PM

View All 30 Files

Subscribers

Details

Reviewers

inka
ginsu

Commits

rCOMMe64e7489b768: [keyserver] Throw an exception when trying to create a DM on a non-auth…

Summary

Currently the DMs are hosted on the authoritative keyserver and can't be created on non-auth ones.

https://linear.app/comm/issue/ENG-7845/stop-creating-dms-on-non-authoritative-keyservers

Depends on D12228

Test Plan

Tested this by removing authoritative keyserver check when creating threads while setting up a new db - this causes an attempt to create a thread in GENESIS. On authoritative keyserver it works. On a non-auth keyserver an exception is thrown - as expected.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.May 28 2024, 5:53 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 28 2024, 5:53 AM

Harbormaster completed remote builds in B29267: Diff 40689.May 28 2024, 6:09 AM

tomek requested review of this revision.May 28 2024, 6:09 AM

Update commit message

tomek edited the test plan for this revision. (Show Details)May 29 2024, 6:38 AM

Harbormaster completed remote builds in B29280: Diff 40741.May 29 2024, 6:55 AM

inka accepted this revision.May 29 2024, 7:21 AM

This revision is now accepted and ready to land.May 29 2024, 7:21 AM

Closed by commit rCOMMe64e7489b768: [keyserver] Throw an exception when trying to create a DM on a non-auth… (authored by tomek). · Explain WhyMay 29 2024, 7:37 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMe64e7489b768: [keyserver] Throw an exception when trying to create a DM on a non-auth….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

thread-creator.js

5 lines

Diff 40748

keyserver/src/creators/thread-creator.js

Loading...