Paths

Table of Contentst

Differential D12367

[lib] Add $ReadOnly wrapper around type spreads in socket-types.js
ClosedPublic
Actions

Authored by ashoat on Jun 8 2024, 3:44 PM.

Details

Reviewers

tomek

Commits

rCOMM0bfa4348b9f7: [lib] Add $ReadOnly wrapper around type spreads in socket-types.js

Summary

Noticed these were missing. For whatever reason in Flow, if you spread something it loses the read-only-ness, and it needs to be re-applied.

Depends on D12366

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 8 2024, 3:44 PM

ashoat added a child revision: D12368: [lib] Rename failuresAfterPolicyAcknowledgment to initFailureCountAfterPolicyAcknowledgment.

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 8 2024, 4:02 PM

Harbormaster failed remote builds in B29557: Diff 41144!

Flow fixes in keyserver

Harbormaster completed remote builds in B29560: Diff 41147.Jun 8 2024, 6:49 PM

ashoat requested review of this revision.Jun 8 2024, 6:49 PM

tomek accepted this revision.Jun 10 2024, 4:50 AM

This revision is now accepted and ready to land.Jun 10 2024, 4:50 AM

Closed by commit rCOMM0bfa4348b9f7: [lib] Add $ReadOnly wrapper around type spreads in socket-types.js (authored by ashoat). · Explain WhyJun 10 2024, 2:03 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM0bfa4348b9f7: [lib] Add $ReadOnly wrapper around type spreads in socket-types.js.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

socket/

fetch-data.js

4 lines

lib/

types/

socket-types.js

24 lines

Diff 41190

View Options

keyserver/src/socket/fetch-data.js