[keyserver][lib] Introduce fetch_pending_updates endpoint
ClosedPublic
Actions

Authored by ashoat on Sat, Jun 8, 3:42 PM.

Details

Reviewers

tomek
kamil

Commits

rCOMM42e8ad056f1e: [keyserver][lib] Introduce fetch_pending_updates endpoint

Summary

This addresses ENG-8088. In a later diff, the client will call this when encountering a socket crash loop. The higher timeout will allow us to download a larger amount of data.

Depends on D12363

Test Plan

In combination with later diffs, I tested as follows:

I created a socket crash loop on a physical iOS device using @inka's create-many-threads-to-trigger-crash-loop.js script (see ENG-8090
I confirmed that the socket was unable to connect prior to my diff stack
I confirmed that after applying my diff stack, the SUCCESS action was dispatched, and the socket was able to connect afterwards

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sat, Jun 8, 3:42 PM

ashoat added a child revision: D12365: [lib] Simplify param to generateOpsForThreadUpdates.

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Jun 8, 4:03 PM

Harbormaster failed remote builds in B29554: Diff 41141!

Harbormaster completed remote builds in B29554: Diff 41141.Sat, Jun 8, 6:40 PM

ashoat requested review of this revision.Sat, Jun 8, 6:40 PM

ashoat added a subscriber: kamil.Sun, Jun 9, 6:13 AM

ashoat added inline comments.

keyserver/src/responders/update-responders.js
13 ↗	(On Diff #41141)	I wonder if we need to do something special here for users that haven't acknowledged the latest policies. I'm worried that eg. the socket normally won't allow those users to connect, but perhaps we're allowing them to circumvent that by just calling this endpoint. cc @kamil, do you recall how the keyserver <> client socket code handles this case?

ashoat added a reviewer: kamil.Sun, Jun 9, 6:13 AM

tomek accepted this revision.Mon, Jun 10, 4:03 AM

tomek added 1 blocking reviewer(s): kamil.

kamil accepted this revision.Mon, Jun 10, 10:01 AM

kamil added inline comments.

keyserver/src/responders/update-responders.js
13 ↗	(On Diff #41141)	When policies are not acknowledged socket should refuse to open. Adding this endpoint shouldn't affect that because this endpoint whenever called should also validate policies, see here.