Page MenuHomePhabricator

[keyserver] Factor out fetchDataForSocketInit
ClosedPublic

Authored by ashoat on Sat, Jun 8, 3:39 PM.
Tags
None
Referenced Files
F2177517: D12363.id41186.diff
Wed, Jul 3, 7:28 AM
Unknown Object (File)
Wed, Jun 26, 3:19 AM
Unknown Object (File)
Fri, Jun 21, 10:46 AM
Unknown Object (File)
Sun, Jun 16, 3:37 PM
Unknown Object (File)
Sun, Jun 16, 10:43 AM
Unknown Object (File)
Sat, Jun 15, 12:31 PM
Unknown Object (File)
Sat, Jun 15, 10:19 AM
Unknown Object (File)
Thu, Jun 13, 3:37 PM
Subscribers
None

Details

Summary

We want to use this in a new endpoint, so I'm factoring it out. This endpoint will be used for recovering from a socket crash loop.

Depends on D12362

Test Plan

I tested socket initialization before and after this and confirmed it still worked correctly.

Note that this is a pure move diff, except for some changes to the pattern of awaits in handleInitialClientSocketMessage, now that fetchDataForSocketInit happens before these three promises start:

processClientResponses(viewer, clientResponses),
isCookieMissingSignedIdentityKeysBlob(viewer.cookieID),
isCookieMissingOlmNotificationsSession(viewer),

I think it's safe to wait until after handleInitialClientSocketMessage to call these.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable