Page MenuHomePhabricator

[keyserver] Factor out fetchDataForSocketInit
ClosedPublic

Authored by ashoat on Sat, Jun 8, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 16, 3:37 PM
Unknown Object (File)
Sun, Jun 16, 10:43 AM
Unknown Object (File)
Sat, Jun 15, 12:31 PM
Unknown Object (File)
Sat, Jun 15, 10:19 AM
Unknown Object (File)
Thu, Jun 13, 3:37 PM
Unknown Object (File)
Mon, Jun 10, 5:04 AM
Unknown Object (File)
Mon, Jun 10, 5:01 AM
Unknown Object (File)
Mon, Jun 10, 4:57 AM
Subscribers
None

Details

Summary

We want to use this in a new endpoint, so I'm factoring it out. This endpoint will be used for recovering from a socket crash loop.

Depends on D12362

Test Plan

I tested socket initialization before and after this and confirmed it still worked correctly.

Note that this is a pure move diff, except for some changes to the pattern of awaits in handleInitialClientSocketMessage, now that fetchDataForSocketInit happens before these three promises start:

processClientResponses(viewer, clientResponses),
isCookieMissingSignedIdentityKeysBlob(viewer.cookieID),
isCookieMissingOlmNotificationsSession(viewer),

I think it's safe to wait until after handleInitialClientSocketMessage to call these.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable