Page MenuHomePhabricator

[keyserver] Factor out fetchDataForSocketInit
ClosedPublic

Authored by ashoat on Jun 8 2024, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 11, 6:43 PM
Unknown Object (File)
Thu, Jul 11, 4:14 PM
Unknown Object (File)
Thu, Jul 11, 11:08 AM
Unknown Object (File)
Thu, Jul 11, 11:08 AM
Unknown Object (File)
Thu, Jul 11, 11:06 AM
Unknown Object (File)
Thu, Jul 11, 11:04 AM
Unknown Object (File)
Sat, Jul 6, 6:07 AM
Unknown Object (File)
Sat, Jul 6, 4:48 AM
Subscribers
None

Details

Summary

We want to use this in a new endpoint, so I'm factoring it out. This endpoint will be used for recovering from a socket crash loop.

Depends on D12362

Test Plan

I tested socket initialization before and after this and confirmed it still worked correctly.

Note that this is a pure move diff, except for some changes to the pattern of awaits in handleInitialClientSocketMessage, now that fetchDataForSocketInit happens before these three promises start:

processClientResponses(viewer, clientResponses),
isCookieMissingSignedIdentityKeysBlob(viewer.cookieID),
isCookieMissingOlmNotificationsSession(viewer),

I think it's safe to wait until after handleInitialClientSocketMessage to call these.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable