Page MenuHomePhabricator
Differential D12437

[lib][web][native] Send CSAT in getKeyserverOverrideForAnInviteLink
ClosedPublic
Actions

Authored by bartek on Thu, Jun 13, 11:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 22, 9:11 PM
Unknown Object (File)
Fri, Jun 21, 6:04 PM
Unknown Object (File)
Wed, Jun 19, 8:34 PM
Unknown Object (File)
Tue, Jun 18, 1:05 PM
Unknown Object (File)
Mon, Jun 17, 10:31 PM
Unknown Object (File)
Mon, Jun 17, 10:29 PM
Unknown Object (File)
Sun, Jun 16, 11:59 AM
Subscribers
ashoat
ginsu

Details

Reviewers
tomek
Commits
rCOMM52de63b4fcc5: [lib][web][native] Send CSAT in getKeyserverOverrideForAnInviteLink
Summary

getKeyserverOverrideForAnInviteLink() performs a Blob Service request but doesn't send Authorization header.
Followed multimedia fetching code and added optional AuthMetadata that is sent if usingCSAT == true.

Test Plan
  • On my local keyserver, created a community and created invite link
  • Opened the link in the browser - invitation was successful.
  • Searched Blob Service debug logs - Authorization header was present.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Thu, Jun 13, 11:40 PM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptThu, Jun 13, 11:40 PM
Harbormaster completed remote builds in B29679: Diff 41316.Thu, Jun 13, 11:57 PM
bartek published this revision for review.Fri, Jun 14, 3:00 AM
bartek edited the test plan for this revision. (Show Details)
tomek accepted this revision.Fri, Jun 14, 5:36 AM
This revision is now accepted and ready to land.Fri, Jun 14, 5:36 AM
ashoat added a subscriber: ginsu.Fri, Jun 14, 2:30 PM

cc @ginsu, as I know the Farcaster channel work is closely modeled after the invite link work, and might have the same problem

bartek mentioned this in D12065: [native] introduce AutoJoinCommunityHandler.Sun, Jun 16, 10:34 PM
bartek added a parent revision: D12446: [native] Send CSAT when fetching blob service media.Tue, Jun 18, 12:33 AM
Closed by commit rCOMM52de63b4fcc5: [lib][web][native] Send CSAT in getKeyserverOverrideForAnInviteLink (authored by bartek). · Explain WhyTue, Jun 18, 2:18 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM52de63b4fcc5: [lib][web][native] Send CSAT in getKeyserverOverrideForAnInviteLink.

Revision Contents
Changeset List

PathSize
lib/
shared/
7 lines
native/
navigation/
16 lines
web/
invite-links/
20 lines

Diff 41436

View Options

lib/shared/invite-links.js

Loading...
View Options

native/navigation/deep-links-context-provider.react.js

Loading...
View Options

web/invite-links/invite-link-handler.react.js

Loading...