Page MenuHomePhabricator

[native] Send CSAT when fetching blob service media
ClosedPublic

Authored by bartek on Jun 17 2024, 3:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 5:39 PM
Unknown Object (File)
Tue, Oct 15, 1:18 AM
Unknown Object (File)
Tue, Oct 15, 1:15 AM
Unknown Object (File)
Sun, Oct 13, 6:36 AM
Unknown Object (File)
Sun, Oct 13, 6:36 AM
Unknown Object (File)
Sun, Oct 13, 6:36 AM
Unknown Object (File)
Sun, Oct 13, 6:36 AM
Unknown Object (File)
Sep 19 2024, 7:14 PM
Subscribers

Details

Summary

fetchAndDecryptMedia performs a Blob Service request but doesn't send Authorization header
unless authMetadata is provided.
Updated the callsite to provide it when usingCommServicesAccessToken = true

Test Plan

Tested locally with CSAT verification enabled for services.
Blob-hosted encrypted media are downloaded and rendered correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
kamil added inline comments.
native/media/encryption-utils.js
421 ↗(On Diff #41377)

I think with authMetadata calling fetchAndDecryptMedia will fail anyway - shouldn't we let this error throw here?

This revision is now accepted and ready to land.Jun 18 2024, 1:30 AM
native/media/encryption-utils.js
421 ↗(On Diff #41377)

Yeah, that's true. For now, I decided to go with a more graceful way though. Anyway, we're going to handle this differently, as a part of ENG-6664