[native] Send CSAT when fetching blob service media
ClosedPublic
Actions

Authored by bartek on Jun 17 2024, 3:26 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMae31755aee5d: [native] Send CSAT when fetching blob service media

Summary

fetchAndDecryptMedia performs a Blob Service request but doesn't send Authorization header
unless authMetadata is provided.
Updated the callsite to provide it when usingCommServicesAccessToken = true

Test Plan

Tested locally with CSAT verification enabled for services.
Blob-hosted encrypted media are downloaded and rendered correctly.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 17 2024, 3:26 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 17 2024, 3:26 AM

Harbormaster completed remote builds in B29708: Diff 41377.Jun 17 2024, 3:43 AM

bartek published this revision for review.Jun 18 2024, 12:33 AM

bartek added a child revision: D12437: [lib][web][native] Send CSAT in getKeyserverOverrideForAnInviteLink.

kamil accepted this revision.Jun 18 2024, 1:30 AM

kamil added inline comments.

native/media/encryption-utils.js
421 ↗	(On Diff #41377)	I think with `authMetadata` calling `fetchAndDecryptMedia` will fail anyway - shouldn't we let this error throw here?

This revision is now accepted and ready to land.Jun 18 2024, 1:30 AM

Closed by commit rCOMMae31755aee5d: [native] Send CSAT when fetching blob service media (authored by bartek). · Explain WhyJun 18 2024, 2:18 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMae31755aee5d: [native] Send CSAT when fetching blob service media.

bartek added inline comments.Jun 18 2024, 4:28 AM

native/media/encryption-utils.js
421 ↗	(On Diff #41377)	Yeah, that's true. For now, I decided to go with a more graceful way though. Anyway, we're going to handle this differently, as a part of ENG-6664

Revision Contents
Changeset List

Path

Size

native/

media/

encryption-utils.js

30 lines

Diff 41435

View Options

native/media/encryption-utils.js

[native] Send CSAT when fetching blob service mediaClosedPublicActions