Page MenuHomePhabricator

[lib/native] lift createUpdateDBOpsForThreadStoreThreadInfos into lib
ClosedPublic

Authored by ginsu on Wed, Jun 19, 5:31 PM.
Tags
None
Referenced Files
F2134861: D12498.id41613.diff
Fri, Jun 28, 8:56 AM
F2130196: D12498.id41606.diff
Thu, Jun 27, 3:37 PM
F2129277: D12498.id41611.diff
Thu, Jun 27, 12:46 PM
F2129242: D12498.id41534.diff
Thu, Jun 27, 12:33 PM
F2128764: D12498.id41535.diff
Thu, Jun 27, 11:19 AM
F2128554: D12498.id41612.diff
Thu, Jun 27, 10:57 AM
F2128410: D12498.id41605.diff
Thu, Jun 27, 10:38 AM
Unknown Object (File)
Thu, Jun 27, 12:02 AM
Subscribers

Details

Summary

With migration 77, I had a huge misunderstanding about the new migration approach. I thought for this migration we needed to create and directly return a new thread store state to redux using .processStoreOperations(). However, we actually should only just return the operations and just return state as is. The threadStore will be read by SQLiteDataHandler which populates redux with the migrated data from the ops.

Anyways, we need this function for both native + web migrations, this diff lifts this function into lib

Depends on D12497

Test Plan

flow + at the end of the stack confirmed that migration 78 works as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, kamil.
ginsu requested review of this revision.Wed, Jun 19, 6:42 PM
This revision is now accepted and ready to land.Wed, Jun 19, 6:55 PM