Page MenuHomePhabricator
Differential D12503

[keyserver/lib/native] flip the switch for farcaster channel tagging
ClosedPublic
Actions

Authored by ginsu on Jun 19 2024, 11:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 10, 6:00 AM
Unknown Object (File)
Thu, Apr 10, 3:44 AM
Unknown Object (File)
Tue, Apr 8, 11:36 PM
Unknown Object (File)
Thu, Apr 3, 8:38 AM
Unknown Object (File)
Thu, Mar 20, 11:55 PM
Unknown Object (File)
Mar 7 2025, 12:31 PM
Unknown Object (File)
Mar 7 2025, 12:31 PM
Unknown Object (File)
Mar 7 2025, 12:31 PM
View All 73 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
kamil
will
Commits
rCOMMb8a0c977b46b: [keyserver/lib/native] flip the switch for farcaster channel tagging
Summary

This diff flips the switch for the farcater channel tagging UI. Please note that this UI is still gated if you don't have an fid yet.

Depends on D12500

Test Plan

Confirmed that with an fid an admin could enter the farcater channel tagging ui

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 19 2024, 11:44 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 19 2024, 11:44 PM
ginsu edited the summary of this revision. (Show Details)Jun 19 2024, 11:46 PM
ginsu added reviewers: ashoat, kamil, will.
ginsu added a parent revision: D12500: [native/web] fix manage farcaster channel tag permission migration.
ginsu added inline comments.Jun 19 2024, 11:49 PM
native/components/community-actions-button.react.js
130 ↗(On Diff #41539)

Getting an fid is gated by usingCommServicesAccessToken so having this here as well is a bit redundant

Harbormaster completed remote builds in B29807: Diff 41539.Jun 20 2024, 12:01 AM
ginsu requested review of this revision.Jun 20 2024, 12:01 AM
ashoat accepted this revision.Jun 20 2024, 4:23 AM
This revision is now accepted and ready to land.Jun 20 2024, 4:23 AM
ginsu updated this revision to Diff 41608.Jun 21 2024, 9:35 AM

rebase before landing

Harbormaster completed remote builds in B29873: Diff 41608.Jun 21 2024, 9:53 AM
Closed by commit rCOMMb8a0c977b46b: [keyserver/lib/native] flip the switch for farcaster channel tagging (authored by ginsu). · Explain WhyJun 21 2024, 9:59 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb8a0c977b46b: [keyserver/lib/native] flip the switch for farcaster channel tagging.

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
31 lines
deleters/
17 lines
lib/
shared/
4 lines
native/
components/
12 lines

Diff 41612

View Options

keyserver/src/creators/farcaster-channel-tag-creator.js

Show First 20 Lines • Show All 531 Lines • ▼ Show 20 Lines return facebook::react::createPromiseAsJSIValue(
DatabaseManager::getQueryExecutor().beginTransaction(); DatabaseManager::getQueryExecutor().beginTransaction();
for (const auto &operation : *storeOpsPtr) { for (const auto &operation : *storeOpsPtr) {
operation->execute(); operation->execute();
} }
if (messages.size() > 0) { if (messages.size() > 0) {
DatabaseManager::getQueryExecutor().addOutboundP2PMessages( DatabaseManager::getQueryExecutor().addOutboundP2PMessages(
messages); messages);
} }
DatabaseManager::getQueryExecutor().captureBackupLogs();
DatabaseManager::getQueryExecutor().commitTransaction(); DatabaseManager::getQueryExecutor().commitTransaction();
} catch (std::system_error &e) { } catch (std::system_error &e) {
error = e.what(); error = e.what();
DatabaseManager::getQueryExecutor().rollbackTransaction(); DatabaseManager::getQueryExecutor().rollbackTransaction();
} }
} }
if (!error.size()) {
DatabaseManager::getQueryExecutor().triggerBackupFileUpload();
}
this->jsInvoker_->invokeAsync([=]() { this->jsInvoker_->invokeAsync([=]() {
if (error.size()) { if (error.size()) {
promise->reject(error); promise->reject(error);
} else { } else {
promise->resolve(jsi::Value::undefined()); promise->resolve(jsi::Value::undefined());
} }
}); });
}; };
▲ Show 20 Lines • Show All 2,995 Lines • Show Last 20 Lines
View Options

keyserver/src/deleters/farcaster-channel-tag-deleters.js

Show First 20 Lines • Show All 531 Lines • ▼ Show 20 Lines return facebook::react::createPromiseAsJSIValue(
DatabaseManager::getQueryExecutor().beginTransaction(); DatabaseManager::getQueryExecutor().beginTransaction();
for (const auto &operation : *storeOpsPtr) { for (const auto &operation : *storeOpsPtr) {
operation->execute(); operation->execute();
} }
if (messages.size() > 0) { if (messages.size() > 0) {
DatabaseManager::getQueryExecutor().addOutboundP2PMessages( DatabaseManager::getQueryExecutor().addOutboundP2PMessages(
messages); messages);
} }
DatabaseManager::getQueryExecutor().captureBackupLogs();
DatabaseManager::getQueryExecutor().commitTransaction(); DatabaseManager::getQueryExecutor().commitTransaction();
} catch (std::system_error &e) { } catch (std::system_error &e) {
error = e.what(); error = e.what();
DatabaseManager::getQueryExecutor().rollbackTransaction(); DatabaseManager::getQueryExecutor().rollbackTransaction();
} }
} }
if (!error.size()) {
DatabaseManager::getQueryExecutor().triggerBackupFileUpload();
}
this->jsInvoker_->invokeAsync([=]() { this->jsInvoker_->invokeAsync([=]() {
if (error.size()) { if (error.size()) {
promise->reject(error); promise->reject(error);
} else { } else {
promise->resolve(jsi::Value::undefined()); promise->resolve(jsi::Value::undefined());
} }
}); });
}; };
▲ Show 20 Lines • Show All 2,995 Lines • Show Last 20 Lines
View Options

lib/shared/community-utils.js

Show First 20 Lines • Show All 531 Lines • ▼ Show 20 Lines return facebook::react::createPromiseAsJSIValue(
DatabaseManager::getQueryExecutor().beginTransaction(); DatabaseManager::getQueryExecutor().beginTransaction();
for (const auto &operation : *storeOpsPtr) { for (const auto &operation : *storeOpsPtr) {
operation->execute(); operation->execute();
} }
if (messages.size() > 0) { if (messages.size() > 0) {
DatabaseManager::getQueryExecutor().addOutboundP2PMessages( DatabaseManager::getQueryExecutor().addOutboundP2PMessages(
messages); messages);
} }
DatabaseManager::getQueryExecutor().captureBackupLogs();
DatabaseManager::getQueryExecutor().commitTransaction(); DatabaseManager::getQueryExecutor().commitTransaction();
} catch (std::system_error &e) { } catch (std::system_error &e) {
error = e.what(); error = e.what();
DatabaseManager::getQueryExecutor().rollbackTransaction(); DatabaseManager::getQueryExecutor().rollbackTransaction();
} }
} }
if (!error.size()) {
DatabaseManager::getQueryExecutor().triggerBackupFileUpload();
}
this->jsInvoker_->invokeAsync([=]() { this->jsInvoker_->invokeAsync([=]() {
if (error.size()) { if (error.size()) {
promise->reject(error); promise->reject(error);
} else { } else {
promise->resolve(jsi::Value::undefined()); promise->resolve(jsi::Value::undefined());
} }
}); });
}; };
▲ Show 20 Lines • Show All 2,995 Lines • Show Last 20 Lines
View Options

native/components/community-actions-button.react.js

Show First 20 Lines • Show All 531 Lines • ▼ Show 20 Lines return facebook::react::createPromiseAsJSIValue(
DatabaseManager::getQueryExecutor().beginTransaction(); DatabaseManager::getQueryExecutor().beginTransaction();
for (const auto &operation : *storeOpsPtr) { for (const auto &operation : *storeOpsPtr) {
operation->execute(); operation->execute();
} }
if (messages.size() > 0) { if (messages.size() > 0) {
DatabaseManager::getQueryExecutor().addOutboundP2PMessages( DatabaseManager::getQueryExecutor().addOutboundP2PMessages(
messages); messages);
} }
DatabaseManager::getQueryExecutor().captureBackupLogs();
DatabaseManager::getQueryExecutor().commitTransaction(); DatabaseManager::getQueryExecutor().commitTransaction();
} catch (std::system_error &e) { } catch (std::system_error &e) {
error = e.what(); error = e.what();
DatabaseManager::getQueryExecutor().rollbackTransaction(); DatabaseManager::getQueryExecutor().rollbackTransaction();
} }
} }
if (!error.size()) {
DatabaseManager::getQueryExecutor().triggerBackupFileUpload();
}
this->jsInvoker_->invokeAsync([=]() { this->jsInvoker_->invokeAsync([=]() {
if (error.size()) { if (error.size()) {
promise->reject(error); promise->reject(error);
} else { } else {
promise->resolve(jsi::Value::undefined()); promise->resolve(jsi::Value::undefined());
} }
}); });
}; };
▲ Show 20 Lines • Show All 2,995 Lines • Show Last 20 Lines