Page MenuHomePhabricator

[native] fix indexing in tag channel button action sheet
ClosedPublic

Authored by ginsu on Jun 21 2024, 11:28 AM.
Tags
None
Referenced Files
F3278209: D12540.diff
Sat, Nov 16, 8:14 AM
Unknown Object (File)
Sun, Nov 3, 4:26 AM
Unknown Object (File)
Sun, Nov 3, 4:26 AM
Unknown Object (File)
Sun, Nov 3, 4:26 AM
Unknown Object (File)
Sun, Nov 3, 4:25 AM
Unknown Object (File)
Sun, Nov 3, 4:25 AM
Unknown Object (File)
Oct 12 2024, 12:58 PM
Unknown Object (File)
Sep 14 2024, 3:11 AM
Subscribers

Details

Summary

As I am working on bringing the channel tagging UI to web, I noticed that the indexing in the tag channel button action sheet was broken. In D11894, I got some feedback to make "Other" appear first rather than at the end. I addressed this feedback; however, I forgot to update the indexing to handle this change, so every option was off by one. This diff should fix this issue

Test Plan

Confirmed that the indexing for tag channel button action sheet works as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage