Page MenuHomePhabricator

[native] handle loading state in TagFarcasterChannelByName
ClosedPublic

Authored by ginsu on Jun 21 2024, 11:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 14, 3:12 AM
Unknown Object (File)
Sat, Sep 14, 3:11 AM
Unknown Object (File)
Sat, Sep 14, 3:11 AM
Unknown Object (File)
Sat, Sep 14, 3:11 AM
Unknown Object (File)
Sat, Sep 14, 3:11 AM
Unknown Object (File)
Sat, Sep 14, 3:11 AM
Unknown Object (File)
Aug 24 2024, 10:50 PM
Unknown Object (File)
Aug 8 2024, 10:24 AM
Subscribers

Details

Summary

As I am working on bringing the channel tagging UI to web, I noticed that I did not properly handle loading states in the TagFarcasterChannelByName screen. We can use the newly introduced useCreateFarcasterChannelTag hook to both fix this omission + simply this component

Test Plan

Confirmed that there is a loading state when attempting to tag a farcaster channel by name

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu added reviewers: inka, kamil.
This revision is now accepted and ready to land.Jun 24 2024, 12:10 AM
This revision was landed with ongoing or failed builds.Jun 24 2024, 10:25 AM
This revision was automatically updated to reflect the committed changes.