Page MenuHomePhabricator
Differential D12552

Refrain from querying blob service from the NSE if CAST is missing
ClosedPublic
Actions

Authored by marcin on Jun 24 2024, 3:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 1:03 PM
Unknown Object (File)
Fri, Nov 1, 1:03 PM
Unknown Object (File)
Fri, Nov 1, 1:03 PM
Unknown Object (File)
Fri, Nov 1, 1:03 PM
Unknown Object (File)
Fri, Nov 1, 1:03 PM
Unknown Object (File)
Fri, Nov 1, 1:02 PM
Unknown Object (File)
Fri, Oct 18, 11:22 PM
Unknown Object (File)
Sep 28 2024, 2:30 PM
View All 59 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
kamil
Commits
rCOMM234060ad2c39: Refrain from querying blob service from the NSE if CAST is missing
Summary

This differential make the NSE bail blob service query if CAST is missing

Test Plan
  1. Send large notification to the native client.
  2. Ensure notif is displayed but the console logs say that blob service query was aborted because there was no CSAT.
  3. Now flip usingCommServicesAccessToken to true.
  4. Ensure large notif is fetched.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-8366
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jun 24 2024, 3:10 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 24 2024, 3:10 AM
marcin added inline comments.Jun 24 2024, 3:11 AM
web/cpp/SQLiteQueryExecutorBindings.cpp
252–262 ↗(On Diff #41634)

Someone forgot to run clang formatting. Let's cover it in this diff.

marcin updated this revision to Diff 41636.Jun 24 2024, 3:17 AM

REmove unnecessary ternary operators from Android code.

Harbormaster completed remote builds in B29890: Diff 41634.Jun 24 2024, 3:26 AM
Harbormaster completed remote builds in B29892: Diff 41636.Jun 24 2024, 3:33 AM
marcin requested review of this revision.Jun 24 2024, 3:33 AM
bartek accepted this revision.Jun 24 2024, 4:00 AM
bartek added inline comments.
native/android/app/src/main/java/app/comm/android/commservices/CommAndroidBlobClient.java
93

You haven't attempted querying so it's better wording

native/ios/Comm/CommIOSServices/CommIOSBlobClient.mm
260

same as above

This revision is now accepted and ready to land.Jun 24 2024, 4:00 AM
kamil accepted this revision.Jun 24 2024, 4:11 AM
marcin updated this revision to Diff 41638.Jun 24 2024, 4:38 AM

Update error message

This revision was landed with ongoing or failed builds.Jun 24 2024, 4:41 AM
Closed by commit rCOMM234060ad2c39: Refrain from querying blob service from the NSE if CAST is missing (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM234060ad2c39: Refrain from querying blob service from the NSE if CAST is missing.
Harbormaster completed remote builds in B29894: Diff 41638.Jun 24 2024, 4:55 AM

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
java/
app/
comm/
android/
commservices/
7 lines
ios/
Comm/
CommIOSServices/
32 lines
web/
cpp/
15 lines

Diff 41636

View Options

native/android/app/src/main/java/app/comm/android/commservices/CommAndroidBlobClient.java

Loading...
View Options

native/ios/Comm/CommIOSServices/CommIOSBlobClient.mm

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...