Paths

Table of Contentst

[lib/native] lift tagFarcasterChannelErrorMessages into lib
ClosedPublic
Actions

Authored by ginsu on Jun 25 2024, 5:29 AM.

Details

Reviewers

inka
kamil

Commits

rCOMM44723816bd0f: [lib/native] lift tagFarcasterChannelErrorMessages into lib

Summary

We will need this in web as well

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 25 2024, 5:29 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 25 2024, 5:29 AM

ginsu edited the summary of this revision. (Show Details)Jun 25 2024, 5:30 AM

ginsu added reviewers: inka, kamil.

ginsu added a parent revision: D12561: [web] Dropdown component improvements.

Harbormaster completed remote builds in B29912: Diff 41672.Jun 25 2024, 5:45 AM

ginsu requested review of this revision.Jun 25 2024, 5:45 AM

ginsu added a child revision: D12566: [web] introduce CreateFarcasterChannelTagModal.Jun 25 2024, 5:56 AM

inka accepted this revision.Jun 27 2024, 1:30 PM

This revision is now accepted and ready to land.Jun 27 2024, 1:30 PM

rebase before landing now because I need this to address feedback in subsquent diffs

ginsu edited the summary of this revision. (Show Details)Jun 28 2024, 6:47 PM

ginsu removed a parent revision: D12561: [web] Dropdown component improvements.

This revision was landed with ongoing or failed builds.Jun 28 2024, 6:50 PM

Closed by commit rCOMM44723816bd0f: [lib/native] lift tagFarcasterChannelErrorMessages into lib. · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM44723816bd0f: [lib/native] lift tagFarcasterChannelErrorMessages into lib.

Harbormaster completed remote builds in B30002: Diff 41813.Jun 28 2024, 7:03 PM

ginsu removed a child revision: D12566: [web] introduce CreateFarcasterChannelTagModal.Jun 28 2024, 7:26 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

community-utils.js

6 lines

native/

community-settings/

tag-farcaster-channel/

tag-farcaster-channel-by-name.react.js

6 lines

tag-farcaster-channel-utils.js

tag-farcaster-channel.react.js

6 lines

Diff 41815

View Options

lib/shared/community-utils.js

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-by-name.react.js

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-utils.js

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

[lib/native] lift tagFarcasterChannelErrorMessages into libClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41815

lib/shared/community-utils.js

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-by-name.react.js

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-utils.js

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

[lib/native] lift tagFarcasterChannelErrorMessages into lib
ClosedPublic
Actions

Revision Contents
Changeset List