Page MenuHomePhabricator
Differential D12565

[lib/native] lift tagFarcasterChannelErrorMessages into lib
ClosedPublic
Actions

Authored by ginsu on Jun 24 2024, 10:29 PM.
Tags
None
Referenced Files
F3612710: D12565.id41672.diff
Wed, Jan 1, 5:17 AM
F3612703: D12565.id.diff
Wed, Jan 1, 5:17 AM
F3612702: D12565.diff
Wed, Jan 1, 5:17 AM
Unknown Object (File)
Sat, Dec 28, 9:51 AM
Unknown Object (File)
Sat, Dec 28, 9:51 AM
Unknown Object (File)
Thu, Dec 12, 6:02 PM
Unknown Object (File)
Nov 13 2024, 3:28 AM
Unknown Object (File)
Nov 13 2024, 3:28 AM
View All 64 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
kamil
Commits
rCOMM44723816bd0f: [lib/native] lift tagFarcasterChannelErrorMessages into lib
Summary

We will need this in web as well

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 24 2024, 10:29 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 24 2024, 10:29 PM
ginsu edited the summary of this revision. (Show Details)Jun 24 2024, 10:30 PM
ginsu added reviewers: inka, kamil.
ginsu added a parent revision: D12561: [web] Dropdown component improvements.
Harbormaster completed remote builds in B29912: Diff 41672.Jun 24 2024, 10:45 PM
ginsu requested review of this revision.Jun 24 2024, 10:45 PM
ginsu added a child revision: D12566: [web] introduce CreateFarcasterChannelTagModal.Jun 24 2024, 10:56 PM
inka accepted this revision.Jun 27 2024, 6:30 AM
This revision is now accepted and ready to land.Jun 27 2024, 6:30 AM
ginsu updated this revision to Diff 41813.Jun 28 2024, 11:47 AM

rebase before landing now because I need this to address feedback in subsquent diffs

ginsu edited the summary of this revision. (Show Details)Jun 28 2024, 11:47 AM
ginsu removed a parent revision: D12561: [web] Dropdown component improvements.
This revision was landed with ongoing or failed builds.Jun 28 2024, 11:50 AM
Closed by commit rCOMM44723816bd0f: [lib/native] lift tagFarcasterChannelErrorMessages into lib (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM44723816bd0f: [lib/native] lift tagFarcasterChannelErrorMessages into lib.
Harbormaster completed remote builds in B30002: Diff 41813.Jun 28 2024, 12:03 PM
ginsu removed a child revision: D12566: [web] introduce CreateFarcasterChannelTagModal.Jun 28 2024, 12:26 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
6 lines
native/
community-settings/
tag-farcaster-channel/
6 lines
6 lines

Diff 41815

View Options

lib/shared/community-utils.js

Loading...
View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-by-name.react.js

Loading...
View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-utils.js

Loading...
View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

Loading...