Page MenuHomePhabricator
Differential D12565

[lib/native] lift tagFarcasterChannelErrorMessages into lib
ClosedPublic
Actions

Authored by ginsu on Mon, Jun 24, 10:29 PM.
Tags
None
Referenced Files
F2152470: D12565.diff
Sun, Jun 30, 3:15 PM
Unknown Object (File)
Sat, Jun 29, 11:40 AM
Unknown Object (File)
Sat, Jun 29, 11:34 AM
Unknown Object (File)
Fri, Jun 28, 5:41 PM
Unknown Object (File)
Tue, Jun 25, 6:14 AM
Unknown Object (File)
Mon, Jun 24, 11:09 PM
Unknown Object (File)
Mon, Jun 24, 11:07 PM
Subscribers
ashoat
tomek

Details

Reviewers
inka
kamil
Commits
rCOMM44723816bd0f: [lib/native] lift tagFarcasterChannelErrorMessages into lib
Summary

We will need this in web as well

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Mon, Jun 24, 10:29 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Jun 24, 10:29 PM
ginsu edited the summary of this revision. (Show Details)Mon, Jun 24, 10:30 PM
ginsu added reviewers: inka, kamil.
ginsu added a parent revision: D12561: [web] Dropdown component improvements.
Harbormaster completed remote builds in B29912: Diff 41672.Mon, Jun 24, 10:45 PM
ginsu requested review of this revision.Mon, Jun 24, 10:45 PM
ginsu added a child revision: D12566: [web] introduce CreateFarcasterChannelTagModal.Mon, Jun 24, 10:56 PM
inka accepted this revision.Thu, Jun 27, 6:30 AM
This revision is now accepted and ready to land.Thu, Jun 27, 6:30 AM
ginsu updated this revision to Diff 41813.Fri, Jun 28, 11:47 AM

rebase before landing now because I need this to address feedback in subsquent diffs

ginsu edited the summary of this revision. (Show Details)Fri, Jun 28, 11:47 AM
ginsu removed a parent revision: D12561: [web] Dropdown component improvements.
This revision was landed with ongoing or failed builds.Fri, Jun 28, 11:50 AM
Closed by commit rCOMM44723816bd0f: [lib/native] lift tagFarcasterChannelErrorMessages into lib (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM44723816bd0f: [lib/native] lift tagFarcasterChannelErrorMessages into lib.
Harbormaster completed remote builds in B30002: Diff 41813.Fri, Jun 28, 12:03 PM
ginsu removed a child revision: D12566: [web] introduce CreateFarcasterChannelTagModal.Fri, Jun 28, 12:26 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
6 lines
native/
community-settings/
tag-farcaster-channel/
6 lines
2 lines

Diff 41672

View Options

lib/shared/community-utils.js

Loading...
View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-by-name.react.js

Loading...
View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-utils.js

Loading...
View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

Loading...