[native] remove call to setCommServicesAuthMetadata
ClosedPublic
Actions

Authored by varun on Tue, Jun 25, 2:59 PM.

Details

Reviewers

marcin
kamil

Commits

rCOMMf00deb35bc7e: [native] remove call to setCommServicesAuthMetadata

Summary

we don't need this call anymore. processAuthResult in identity-service-context-provider.react.js handles calling setCommServicesAuthMetadata.

Test Plan

tested backup upload and restore protocol, both were successful

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Tue, Jun 25, 2:59 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Jun 25, 2:59 PM

Harbormaster completed remote builds in B29926: Diff 41700.Tue, Jun 25, 3:20 PM

varun requested review of this revision.Tue, Jun 25, 3:20 PM

One note here:
This code was allowing us to test backup also on prod, which helped us catch some bugs, and that's why we kept it even if identity-service-context-provider.react.js was capable of doing that - but since the backup is now authenticated I think we can remove this (D12508, cc. @bartek).

This revision is now accepted and ready to land.Thu, Jun 27, 2:25 AM

Closed by commit rCOMMf00deb35bc7e: [native] remove call to setCommServicesAuthMetadata (authored by varun). · Explain WhyThu, Jun 27, 10:52 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMf00deb35bc7e: [native] remove call to setCommServicesAuthMetadata.