[landing] add download icon to mobile nav
ClosedPublic
Actions

Authored by ginsu on Jun 27 2024, 10:26 AM.

Details

Reviewers

ashoat
inka

Commits

rCOMMa738036b200a: [landing] add download icon to mobile nav

Summary

We also need to introduce the download icon to our mobile nav

Depends on D12591

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jun 27 2024, 10:26 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 27 2024, 10:26 AM

ginsu edited the summary of this revision. (Show Details)Jun 27 2024, 10:28 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, inka.

ginsu added a parent revision: D12591: [landing] add link to download page in the header.

ginsu added inline comments.

landing/mobile-nav.css
11–13 ↗	(On Diff #41761)	Something prettier updated

Harbormaster completed remote builds in B29963: Diff 41761.Jun 27 2024, 10:43 AM

ginsu requested review of this revision.Jun 27 2024, 10:43 AM

ashoat accepted this revision.Jul 1 2024, 12:13 PM

ashoat mentioned this in D12591: [landing] add link to download page in the header.

This revision is now accepted and ready to land.Jul 1 2024, 12:14 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 1 2024, 12:31 PM

Closed by commit rCOMMa738036b200a: [landing] add download icon to mobile nav (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMa738036b200a: [landing] add download icon to mobile nav.

Harbormaster completed remote builds in B30033: Diff 41857.Jul 1 2024, 12:48 PM

Revision Contents
Changeset List

Path

Size

landing/

mobile-nav.css

5 lines

mobile-nav.react.js

17 lines

Diff 41857

View Options

landing/mobile-nav.css